I'm not sure at what point artifacts are constructed from the dependencies in the project file. But calls to isClasspathDep will need to look up the artifact instead of the dep, then call artifact.getType().isClasspathDependency(); (I think artifact.getType() returns an aritfacttype?)
This isn't a high priority, its just a small refactoring to avoid duplicating the ejb/jar check. I've added applet as another type like this in a patch attached to an issue (MAVEN 663 I think). Maybe that is the appropriate place to put this. - Brett > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Tuesday, 12 August 2003 3:44 PM > To: Maven Developers List > Subject: RE: cvs commit: > maven/src/java/org/apache/maven/project Project.j ava > > > Ok, will look into it....how will this change the code? > -- > dIon Gillard, Multitask Consulting > Blog: http://blogs.codehaus.org/people/dion/ > > > Brett Porter <[EMAIL PROTECTED]> wrote on 12/08/2003 > 02:56:40 PM: > > > ArtifactType considers ejb a type (which is what dep.type will be), > > but > also > > knows the filename extension is ".jar". > > > > IMO it makes sense to keep this logic together. > > > > - Brett > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > > Sent: Tuesday, 12 August 2003 2:58 PM > > > To: Maven Developers List > > > Subject: RE: cvs commit: > > > maven/src/java/org/apache/maven/project Project.j ava > > > > > > > > > What's the difference between dependency.type and ArtifactType? > > > -- > > > dIon Gillard, Multitask Consulting > > > Blog: http://blogs.codehaus.org/people/dion/ > > > > > > > > > Brett Porter <[EMAIL PROTECTED]> wrote on 11/08/2003 > > > 04:32:38 PM: > > > > > > > Should this be working with Artifacts? That way, this > > > method could be > > > > in ArtifactType. > > > > > > > > > /** > > > > > - * Currently this is just jars. > > > > > + * Jars and ejbs. > > > > > * > > > > > * @param d > > > > > * @return true if the given dependency belongs on the > > > > > classpath > > > > > */ > > > > > private boolean isClasspathDependency(Dependency d) > > > > > { > > > > > - return d.getType().equals( "jar" ); > > > > > + return d.getType().equals( "jar" ) || > > > > > d.getType().equals( "ejb" ); > > > > > } > > > > > > > > Cheers, > > > > Brett > > > >
