Yep, the use of betwixt vs xpp3 in HEAD is interesting. Maybe you could back port just the XPP3 marshall/demarshall from HEAD into the stable branch?? -- dIon Gillard, Multitask Consulting Blog: http://blogs.codehaus.org/people/dion/
Brett Porter <[EMAIL PROTECTED]> wrote on 14/08/2003 11:12:01 AM: > I see your point with classes12.zip - I always rename it anyway :) > > Maybe artifact type should know whether it is a classpath one or not? > > Anyway, as long as the ejb || jar check is in one place only I'm happy. > > The main problem I'm having with these classes at the moment is the flow of > construction because of betwixt. I want to change all the directories to > File objects for Maven-522... > > - Brett > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > Sent: Thursday, 14 August 2003 10:53 AM > > To: Maven Developers List > > Subject: RE: cvs commit: > > maven/src/java/org/apache/maven/project Project.j ava > > > > > > Bummer, > > > > I have a locally changed copy of Project.java that is waiting on my > > PluginManager changes and tests to get compiled. > > > > In that copy, I moved the code to Dependency, in that it > > seemed a more > > natural place to put the test, i.e. we deal with dependencies in the > > project.xml, not artifacts, and whether it would be placed on the > > classpath seemed to be a dependency thing, i.e. if it was an > > EJB or JAR > > dependency, rather than a .jar extension, as the artifact may be > > classes12.zip for example. > > -- > > dIon Gillard, Multitask Consulting > > Blog: http://blogs.codehaus.org/people/dion/ > > > > > > Brett Porter <[EMAIL PROTECTED]> wrote on 14/08/2003 > > 10:14:33 AM: > > > > > Hi dIon, > > > > > > I fixed this up last night and removed all the references > > to if jar || > > ejb. > > > Turns out dep.getType() gets an ArtifactType, so I put > > isClasspathDep > > > in there and just return getExtension().equals("jar"). So > > no need to > > > look > > into > > > it. > > > > > > Cheers, > > > Brett > > > > > > > -----Original Message----- > > > > From: Brett Porter > > > > Sent: Tuesday, 12 August 2003 4:01 PM > > > > To: 'Maven Developers List' > > > > Subject: RE: cvs commit: > > > > maven/src/java/org/apache/maven/project Project.j ava > > > > > > > > > > > > I'm not sure at what point artifacts are constructed from the > > > > dependencies in the project file. But calls to isClasspathDep > > > > will need to look up the artifact instead of the dep, then > > > > call artifact.getType().isClasspathDependency(); (I think > > > > artifact.getType() returns an aritfacttype?) > > > > > > > > This isn't a high priority, its just a small refactoring to > > > > avoid duplicating the ejb/jar check. > > > > > > > > I've added applet as another type like this in a patch > > > > attached to an issue (MAVEN 663 I think). Maybe that is the > > > > appropriate place to put this. > > > > > > > > - Brett > > > > > > > > > -----Original Message----- > > > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > > > > Sent: Tuesday, 12 August 2003 3:44 PM > > > > > To: Maven Developers List > > > > > Subject: RE: cvs commit: > > > > > maven/src/java/org/apache/maven/project Project.j ava > > > > > > > > > > > > > > > Ok, will look into it....how will this change the code? > > > > > -- > > > > > dIon Gillard, Multitask Consulting > > > > > Blog: http://blogs.codehaus.org/people/dion/ > > > > > > > > > > > >
