> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: 18 August 2003 09:14 > To: Maven Developers List > Subject: RE: cvs commit: maven/src/plugins-build/cactus project.xml > > "Vincent Massol" <[EMAIL PROTECTED]> wrote on 18/08/2003 05:03:43 PM: > > > dIon, > > > > When you make updates like this one, do you test the plugin to see if it > > still works? In this case, you would need to test the plugin on a > > project which uses the Cactus/HttpUnit integration. > Nope, nothing other than the test cases the plugin has. If it still works, > I go ahead with it.
That's already good :-). Have you noticed that I have one sample in the cactus plugin which acts as a functional test for the plugin (although not automated... *sigh*)? Note though that your previous change (related to xerces and xml-apis) had not been tested or the sample would have shown the error... ;-) > > > My point is that I don't believe this is right for you to make this > > modification as I don't think you know enough about the plugin. For > > example, you recently changed some other dependencies for the Cactus > > plugin and as a consequence you broke it. I then had several emails on > > the Cactus mailing list about issues and I had to track that down all > > the way till I found what you did... I was on holiday and it wasn't what > > I would have preferred doing... > Ok, I promise not to touch the cactus plugin. No, you can touch it provided you take responsibility for the change! :-) > > I'd really like test cases though so that the plugins aren't so fragile. +10! > > What needs to be done to set this up for cactus? I've got quite a few > cactified projects at the office, and have used cactus a lot, but not the > plugin. Nekohtml is used by HttpUnit. Thus I guess to verify it works we simply need a Cactus test case that uses HttpUnit. I have just added one such test but it needs to be improved as I don't think it currently does any HTML parsing. Anyway that should be a good enough start. Feel free to commit your change after you verify it works with the sample application. Thanks -Vincent > -- > dIon Gillard, Multitask Consulting > Blog: http://blogs.codehaus.org/people/dion/ > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
