dion 2003/08/20 21:34:34
Modified: src/java/org/apache/maven/jelly MavenJellyContext.java
Log:
System.out -> log
Checkstyle bits
Revision Changes Path
1.34 +18 -6 maven/src/java/org/apache/maven/jelly/MavenJellyContext.java
Index: MavenJellyContext.java
===================================================================
RCS file: /home/cvs/maven/src/java/org/apache/maven/jelly/MavenJellyContext.java,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- MavenJellyContext.java 19 Aug 2003 04:28:15 -0000 1.33
+++ MavenJellyContext.java 21 Aug 2003 04:34:34 -0000 1.34
@@ -63,6 +63,8 @@
import org.apache.commons.jelly.XMLOutput;
import org.apache.commons.jelly.expression.Expression;
import org.apache.commons.lang.StringUtils;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.maven.MavenConstants;
import org.apache.maven.MavenSession;
import org.apache.maven.jelly.tags.jeez.MavenJeezTagLibrary;
@@ -92,6 +94,9 @@
public class MavenJellyContext
extends JellyContext
{
+ /** log for output */
+ private Log log = LogFactory.getLog(MavenJellyContext.class);
+
// ----------------------------------------------------------------------
// C O N S T R U C T O R S
// ----------------------------------------------------------------------
@@ -124,6 +129,10 @@
initializeContext();
}
+ /**
+ * Create a context with this as the parent
+ * @return a new context
+ */
protected JellyContext createChildContext()
{
return new MavenJellyContext(this);
@@ -159,7 +168,7 @@
*/
public void registerTagLibrary( String uri, TagLibrary taglib )
{
- if ( isTagLibraryRegistered( uri ) == false )
+ if ( !isTagLibraryRegistered( uri ) )
{
super.registerTagLibrary( uri, taglib );
}
@@ -181,7 +190,7 @@
public void registerTagLibrary( String namespaceURI,
String className )
{
- if ( isTagLibraryRegistered( namespaceURI ) == false )
+ if ( !isTagLibraryRegistered( namespaceURI ) )
{
super.registerTagLibrary( namespaceURI, className );
}
@@ -259,7 +268,7 @@
/**
* Set the mavenSession attribute.
*
- * @param mavenSession
+ * @param mavenSession the session for the context
*/
public void setMavenSession( MavenSession mavenSession )
{
@@ -641,15 +650,18 @@
return (GrantProject) getVariable( MavenConstants.MAVEN_ANT_PROJECT );
}
+ /**
+ * Display all maven variables
+ */
public void display()
{
- for (Iterator i = getVariableNames(); i.hasNext(); )
+ for (Iterator i = getVariableNames(); i.hasNext();)
{
String key = (String) i.next();
if ( key.startsWith("maven"))
{
- System.out.println(key + ": " + getVariable( key ));
+ log.info(key + ": " + getVariable( key ));
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
