The following comment has been added to this issue:
Author: John Casey
Created: Mon, 8 Dec 2003 3:18 PM
Body:
Cross-posted with issues:
MPARTIFACT-4
MPEJB-2
The post to MPEJB-2 is actually an addendum to previous comments by other users, with
a new patch.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-1068
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1068
Summary: adding EJB-client support to ArtifactType, Dependency
Type: Improvement
Status: Unassigned
Priority: Minor
Original Estimate: 30 minutes
Time Spent: Unknown
Remaining: 30 minutes
Project: maven
Components:
core
Versions:
1.0-rc2
Assignee:
Reporter: John Casey
Created: Mon, 8 Dec 2003 2:50 PM
Updated: Mon, 8 Dec 2003 3:18 PM
Environment: any
Description:
The current ArtifactType enumeration does not include support for EJB-client jars. In
fact, the ejb plugin currently fabricates the jar name and has no support for handling
the EJB-client jar, only creating it in the ${maven.build.dir} directory. In addition,
the Dependency class cannot recognize EJB-client jars by type and add them to the
classpath.
I propose adding an EJB_CLIENT ArtifactType with type="ejb-client" and
extension="client.jar". This will result in repository pathing of
<group-id>/ejb-clients/<artifact-id>.client.jar for vanilla EJB projects.
Toward this goal, I have modified the ArtifactType.findType() method to search an
array containing all type constants, in order to simplify future additions to this
class.
I also added an ArtifactType.JAR constant, for consistency.
Finally, I modified the Dependency.isAddedToClasspath() method to use the ArtifactType
constants for JAR, EJB, and EJB_CLIENT for comparisons with the stated type name, and
finally returning false if none of these match on the getType() method.
I will be submitting another patch against the maven-plugins project, for the ejb
plugin and the artifact plugin...this patch (which I guess I'll submit to both MPxxx
pseudo-projects on JIRA...) will enable EJB-client support and improve the artifact
plugin to take full advantage of the ArtifactType enumeration. I'll update this issue
with the appropriate JIRA issue ID's when I have them.
Attached is a patch for the maven-core.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
