The following comment has been added to this issue:

     Author: Tim Chen
    Created: Thu, 15 Jan 2004 6:54 AM
       Body:
Thanks Michal. But that's exactly what I was talking about.
But that kind of work around in my mind isn't suffering from performance but rather 
from the concept of what war plugin should do. A valid war can have multiple files 
directly under WEB-INF. I know that this is supported in the sense that 
webapps/WEB-INF files can be incorporated but for autogenerated files this is not 
where they usually reside. I'm sure it's more of a question of preference and I don't 
want it to become a religious debate but it would be nice to have this functionality 
(hence the improvement type ;)
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPWAR-16


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPWAR-16
    Summary: war plugin cannot add other files to web-inf without workaround
       Type: Improvement

     Status: Open
   Priority: Major

 Original Estimate: 30 minutes
 Time Spent: Unknown
  Remaining: 30 minutes

    Project: maven-war-plugin

   Assignee: Jason van Zyl
   Reporter: Tim Chen

    Created: Wed, 14 Jan 2004 4:33 PM
    Updated: Thu, 15 Jan 2004 6:54 AM
Environment: maven 1.0 rc-1
war plugin 1.4 and 1.5 SNAPSHOT

Description:
Consider a struts war which might have:

WEB-INF/
  web.xml
  struts-config.xml

The current war plugin does not allow you to copy struts-config.xml into WEB-INF 
without a maven.xml postgoal hack.

A possible patch would be to add the following to war:webapp

<ant:copy todir="${webapp.build.webinf}">
   <ant:fileset dir="${maven.war.webxml.src}"
       includes="${maven.war.webxml.src.includes}"
       excludes="${maven.war.webxml.src.excludes}"/>
</ant:copy>

an example project.properties using this would be:
maven.xdoc.date=left
maven.xdoc.version=${pom.currentVersion}
maven.multiproject.type=war

maven.xdoclet.webdoclet.destDir=${maven.build.dir}/xdoclet/webdoclet/WEB-INF
maven.xdoclet.webdoclet.mergeDir=${maven.src.dir}/merge
maven.xdoclet.webdoclet.fileset.0.include=**/*.java
maven.xdoclet.webdoclet.strutsconfigxml.0=true
maven.xdoclet.webdoclet.strutsconfigxml.0.Version=1.1
maven.xdoclet.webdoclet.strutsconfigxml.0.mergeDir=${maven.src.dir}/merge
maven.xdoclet.webdoclet.jsptaglib.0=false

maven.war.src=${maven.xdoclet.webdoclet.dir}
maven.war.webxml=${maven.xdoclet.webdoclet.destDir}/web.xml
maven.war.webxml.src=${maven.xdoclet.webdoclet.destDir}
maven.war.webxml.src.includes=struts*.xml

The proposed patch could be enhanced by ignoring web.xml if it is in the same 
directory etc.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to