> First the use documentation would be great if you could provide it as a > patch as well... I can do that. Just let me know the path to the existing documentation and I'll attach a separate patch to the JIRA. > Would it be possible to make two separate jira's for each of them? For > each rule one? Both rules call out to same utility classes. If I separated the rules, I'd either have to include the utility classes in both patches or make the 2nd JIRA dependent on the first. That's why I put them in one patch. If you still insist, let me know. Regards,Abhijit
> Date: Sat, 21 Feb 2015 20:05:20 +0100 > From: khmarba...@gmx.de > To: dev@maven.apache.org > Subject: Re: How to contribute new maven enforcer rules > > Hi, > > On 2/21/15 7:43 PM, Abhijit Sarkar wrote: > > Done. http://jira.codehaus.org/browse/MENFORCER-225 > > First looks good so far but i have two little things. > > First the use documentation would be great if you could provide it as a > patch as well... > > Ah...one other thing.... > > Would it be possible to make two separate jira's for each of them? For > each rule one? > > Apart from that i don't see any objections to apply your patches to the > project...currently i'm working on some regressions in > Enforcer...afterwards i will continue with your patches...so it could > take some days... > > Thanks in advance...for your help and your contributions... > > Kind regards > Karl Heinz Marbaise > > > > >> Date: Sat, 21 Feb 2015 13:46:12 +0100 > >> From: khmarba...@gmx.de > >> To: dev@maven.apache.org > >> Subject: Re: How to contribute new maven enforcer rules > >> > >> Hi, > >> > >> > >> On 2/20/15 8:55 PM, Abhijit Sarkar wrote: > >>> Hi,I wrote 2 new enforces rules, the ability to specify a set of > >>> mutually-exclusive profiles (p1,p2:p1,p3 would mean p1 can't be active > >>> with either p2 pr p3) and the ability to ban profiles (the contrary of > >>> requireActiveProfile). Both of these support wildcards. > >>> I'd like to contribute these rules back to the enforces-rulles project. > >>> How do I do that? > >>> Regards,Abhijit Sarkar > >>> > >>> > >> > >> the best is to create an appropriate JIRA entry and attach an > >> appropriate patch include unit tests depending on the size maybe an > >> integration test might be worth... > >> > >> Kind regards > >> Karl Heinz Marbaise > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org >
