GitHub user Stephan202 opened a pull request:

    https://github.com/apache/maven/pull/40

    MNG-5786: Fix edge case in determining maven.multiModuleProjectDirectory.

    See [MNG-5786](https://jira.codehaus.org/browse/MNG-5786) for details. The 
commit message explains the issue in different words:
    
        MNG-5786: Fix maven.multiModuleProjectDirectory.
        
        Fixes an edge case where maven.multiModuleProjectDirectory is set 
incorrectly.
        Consider the following scenario:
        
          /some/path/to/the/workspace/.mvn
          /some/path/to/the/workspace/project/.mvn
          /some/path/to/the/workspace/project/pom.xml
        
        Prior to the fix, running Maven inside the *project* directory will 
cause
        maven.multiModuleProjectDirectory to be set to the *workspace* 
directory. The
        fix entails testing for the presence of .mvn before traversing one 
directory
        up, rather than afterwards.
        
        The loop termination condition was moved inside the loop, so as to 
ensure that
        .mvn can also be placed in the file system root.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Stephan202/maven MNG-5786

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 5374bfcaff59414ca9b580cefbab8880bf782d42
Author: Stephan Schroevers <[email protected]>
Date:   2015-03-18T13:18:18Z

    MNG-5786: Fix maven.multiModuleProjectDirectory.
    
    Fixes an edge case where maven.multiModuleProjectDirectory is set 
incorrectly.
    Consider the following scenario:
    
      /some/path/to/the/workspace/.mvn
      /some/path/to/the/workspace/project/.mvn
      /some/path/to/the/workspace/project/pom.xml
    
    Prior to the fix, running Maven inside the *project* directory will cause
    maven.multiModuleProjectDirectory to be set to the *workspace* directory. 
The
    fix entails testing for the presence of .mvn before traversing one directory
    up, rather than afterwards.
    
    The loop termination condition was moved inside the loop, so as to ensure 
that
    .mvn can also be placed in the file system root.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to