Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/45#issuecomment-97413566
To be clear are you saying that the injection of loggers is not supported
with Guice 4? I don't think it's used much but I believe it is used. Yes, I
have been using the static factory method, or lombok.
Maybe this is the impetus to get the perf harness back up and running to
check. I'll merge it here locally and try it for a week.
On Apr 29, 2015, at 6:03 AM, Stuart McCulloch <[email protected]>
wrote:
> The only difference remaining between this and sisu-guice is support for
@Injection of SLF4J loggers, but I don't believe that's used much, if at all.
Personally these days I prefer to create loggers using the static factory
method.
>
> Performance should be comparable, although I have yet to run a detailed
comparison - I'd be interested in feedback from people using large or
complicated builds.
>
> �
> Reply to this email directly or view it on GitHub.
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Takari and Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------
A master in the art of living draws no sharp distinction between his work
and his play; his labor and his leisure; his mind and his body; his education
and his recreation. He hardly knows which is which. He simply pursues his
vision of excellence through whatever he is doing, and leaves others to
determine whether he is working or playing. To himself, he always appears to be
doing both.
-- Fran�ois-Ren� de Chateaubriand
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
