OK so MNG-2199 introduced the regression MNG-5840.... There was a claim in the introduction of MNG-2199 that there was some validation in the workspace resolver:
https://github.com/apache/maven/blob/25f5143169d39075cee67d9f4d11649cce0fafa0/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L938 The tests I have added in https://github.com/apache/maven-integration-testing/commit/f2d3d7a0244a6401514662a5f2cfcca7eca706e4 show that the claim was incorrect. With my change in https://github.com/apache/maven/blob/25f5143169d39075cee67d9f4d11649cce0fafa0 we keep MNG-5840 fixed for non version range parents (which is good) but those that have a version range will fall foul to MNG-5840 (which IMHO is very very bad) Short of pulling the version range parsing code up into model builder or introducing a dependency on maven-artifact to model-builder I cannot see any simple way to fix the issue of the parent version range. If somebody wants to take a stab at figuring out the workspace resolver version, they are welcome to try. https://github.com/apache/maven/pull/60 Is one potential (ugly IMHO) fix. It might suffice for an interim release, as I view MNG-5840 as very evil and a blocker to anyone using 3.3.x, until such time as the workspace resolver actually has the validation code On 22 July 2015 at 08:49, Stephen Connolly <stephen.alan.conno...@gmail.com> wrote: > Igor, > > Seems that we are missing integration tests for that feature. I suspect > that this is a regression introduced in fixing the MNG-5840 regression. > > I have committed a partial fix (i.e. fixes MNG-5840 for non-version > ranges) and I have some integration tests for with version ranges to see if > the claimed workspace validation actually takes place with a version range. > > On 22 July 2015 at 00:57, Igor Fedorenko <i...@ifedorenko.com> wrote: > >> -1 FWIW >> >> There is a regression with parent pom version range support (see >> MNG-2199 [1]) when locating locally-available parent pom. I've pushed >> MavenITmng2199ParentVersionRangeTest#testValidLocalParentVersionRange >> regression test [2] to demonstrate the issue. The test works with Maven >> 3.3.3 but fails with current master. Staged 3.3.5 does not work for our >> internal build, however. >> >> >> [1] https://issues.apache.org/jira/browse/MNG-2199 >> [2] >> >> https://git1-us-west.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=b015e1cf9860fa9f3725a4393d7a0dc8a0868b2f >> >> -- >> Regards, >> Igor >> >> On Tue, Jul 21, 2015, at 01:12 PM, Tibor Digana wrote: >> > +1 non-binding from me. >> > Now my IDEA works fine with 3.3.5. >> > >> > On Tue, Jul 21, 2015 at 4:58 PM, stephenconnolly [via Maven] < >> > ml-node+s40175n5840520...@n5.nabble.com> wrote: >> > >> > > FYI Tibor, that is not a regression against 3.3.3 from my >> understanding >> > > >> > > On 21 July 2015 at 14:30, Tibor Digana <[hidden email] >> > > <http:///user/SendEmail.jtp?type=node&node=5840520&i=0>> wrote: >> > > >> > > > +0 (non-binding) >> > > > The IntelliJ IDEA does not launch Maven build. >> > > > It looks like the reason is that we changed file name from >> bin/mvn.bat >> > > to >> > > > bin/mvn.cmd. >> > > > Is it only me who has this problem in IDEA, can you check it out as >> > > well? >> > > > >> > > > On Mon, Jul 20, 2015 at 9:23 PM, Jason van Zyl <[hidden email] >> > > <http:///user/SendEmail.jtp?type=node&node=5840520&i=1>> wrote: >> > > > >> > > > > Hi, >> > > > > >> > > > > Time to release Maven 3.3.5! >> > > > > >> > > > > Here is a link to the issues resolved: >> > > > > >> > > > > >> > > > >> > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12333058 >> > > > > >> > > > > Staging repo: >> > > > > https://repository.apache.org/content/repositories/maven-1200/ >> > > > > >> > > > > The distributable binaries and sources for testing can be found >> here: >> > > > > >> > > > > >> > > > >> > > >> https://repository.apache.org/content/repositories/maven-1200/org/apache/maven/apache-maven/3.3.5/ >> > > > > >> > > > > Specifically the zip, tarball, and source archives can be found >> here: >> > > > > >> > > > > >> > > > >> > > >> https://repository.apache.org/content/repositories/maven-1200/org/apache/maven/apache-maven/3.3.5/apache-maven-3.3.5-bin.zip >> > > > > >> > > > > >> > > > >> > > >> https://repository.apache.org/content/repositories/maven-1200/org/apache/maven/apache-maven/3.3.5/apache-maven-3.3.5-bin.tar.gz >> > > > > >> > > > > >> > > > >> > > >> https://repository.apache.org/content/repositories/maven-1200/org/apache/maven/apache-maven/3.3.5/apache-maven-3.3.5-src.zip >> > > > > >> > > > > >> > > > >> > > >> https://repository.apache.org/content/repositories/maven-1200/org/apache/maven/apache-maven/3.3.5/apache-maven-3.3.5-src.tar.gz >> > > > > >> > > > > Source release checksum(s): >> > > > > apache-maven-3.3.5-src.zip sha1: >> > > f2b28783fbf9a4fda47d2924a29aa99b9dc7b898 >> > > > > >> > > > > Staging site: >> > > > > http://people.apache.org/~jvanzyl/maven-3.3.5/ >> > > > > >> > > > > Vote open for 72 hours. >> > > > > >> > > > > [ ] +1 >> > > > > [ ] +0 >> > > > > [ ] -1 >> > > > > >> > > > > Thanks, >> > > > > >> > > > > The Maven Team >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> --------------------------------------------------------------------- >> > > > > To unsubscribe, e-mail: [hidden email] >> > > <http:///user/SendEmail.jtp?type=node&node=5840520&i=2> >> > > > > For additional commands, e-mail: [hidden email] >> > > <http:///user/SendEmail.jtp?type=node&node=5840520&i=3> >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> --------------------------------------------------------------------- >> > > > > To unsubscribe, e-mail: [hidden email] >> > > <http:///user/SendEmail.jtp?type=node&node=5840520&i=4> >> > > > > For additional commands, e-mail: [hidden email] >> > > <http:///user/SendEmail.jtp?type=node&node=5840520&i=5> >> > > > > >> > > > > >> > > > >> > > >> > > >> > > ------------------------------ >> > > If you reply to this email, your message will be added to the >> discussion >> > > below: >> > > >> http://maven.40175.n5.nabble.com/VOTE-Maven-3-3-5-tp5840486p5840520.html >> > > To start a new topic under Maven Developers, email >> > > ml-node+s40175n142166...@n5.nabble.com >> > > To unsubscribe from Maven Developers, click here >> > > < >> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg== >> > >> > > . >> > > NAML >> > > < >> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml >> > >> > > >> > >> > >> > >> > >> > -- >> > View this message in context: >> > >> http://maven.40175.n5.nabble.com/VOTE-Maven-3-3-5-tp5840486p5840527.html >> > Sent from the Maven Developers mailing list archive at Nabble.com. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> >
