Hi Herve, I did this because seems like a parser can be of type XML even if it's not parsing only XML - for example the MarkdownParser (which is in doxia and extends from the XmlParser) getType() returns 2 (XML parser type). I guess there are two ways to go here - 1) first would be to allow the user to force an encoding. It's his/hers decision and he/she takes the responsibility. 2) Would be to override the XmlParser:getType() method in MarkdownParser and make it return 0 (UNKNOWN_TYPE). To me this would lead to inconsistency, because the MarkdownParser extends from XmlParser, but returns another type. Furthermore I don't agree markdown syntax is in fact xml syntax.
2015-08-11 11:04 GMT+03:00 <[email protected]>: > wow, I don't like this > in XML, encoding is self provided > > with such feature, an XML-invalid document can be read by Maven (and Maven > only, since it is XML-invalid) > > I'm -1 on this: we can't help people make Maven-specific pseudo XML > > Regards, > > Hervé > > ----- Mail original ----- > De: [email protected] > À: [email protected] > Envoyé: Lundi 10 Août 2015 20:00:00 > Objet: svn commit: r1695142 - > /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java > > Author: ptahchiev > Date: Mon Aug 10 18:00:00 2015 > New Revision: 1695142 > > URL: http://svn.apache.org/r1695142 > Log: > Check for user's provided encoding, and only if it's null then use the > encoding of the xml document. Closes [DOXIASITETOOLS-104] > > Modified: > > maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java > > Modified: > maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java > URL: > http://svn.apache.org/viewvc/maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java?rev=1695142&r1=1695141&r2=1695142&view=diff > > ============================================================================== > --- > maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java > (original) > +++ > maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java > Mon Aug 10 18:00:00 2015 > @@ -389,7 +389,14 @@ public class DefaultSiteRenderer > switch ( parser.getType() ) > { > case Parser.XML_TYPE: > - reader = ReaderFactory.newXmlReader( doc ); > + if ( siteContext.getInputEncoding() != null ) > + { > + reader = ReaderFactory.newReader( doc, > siteContext.getInputEncoding() ); > + } > + else > + { > + reader = ReaderFactory.newXmlReader( doc ); > + } > if ( siteContext.isValidate() ) > { > reader = validate( reader, resource ); > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Regards, Petar! Karlovo, Bulgaria. --- Public PGP Key at: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x19658550C3110611 Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611
