PS. you should also update animal-sniffer-maven-plugin to 1.14 to pick up the fix for MANIMALSNIFFER-49
On Wednesday, 16 September 2015 at 10:20, Stuart McCulloch wrote: > Hi Robert, > > Apply this patch which contains a fix for deep classpath scanning under > Jigsaw (this mode isn’t used by Maven at runtime, just this test) > > https://github.com/apache/maven/pull/66 > > or alternatively change DefaultMavenExecutionRequestPopulatorTest to use the > component index rather than deep classpath scanning: > > diff --git > a/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionRequestPopulatorTest.java > > b/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionRequestPopulatorTest.java > index 15a7a7b..b86198b 100644 > --- > a/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionRequestPopulatorTest.java > +++ > b/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionRequestPopulatorTest.java > @@ -29,6 +29,8 @@ > * under the License. > */ > > +import org.eclipse.sisu.space.BeanScanning; > + > public class DefaultMavenExecutionRequestPopulatorTest > extends InjectedTestCase > { > @@ -59,4 +61,10 @@ public void testPluginRepositoryInjection() > assertEquals( r.getId(), repositories.get( 0 ).getId() ); > assertEquals( r.getUrl(), repositories.get( 0 ).getUrl() ); > } > + > + @Override > + public BeanScanning scanning() > + { > + return BeanScanning.GLOBAL_INDEX; > + } > } > > > On Wednesday, 16 September 2015 at 09:55, Robert Scholte wrote: > > > I'm just going to continue with the next failure: > > > > ------------------------------------------------------------------------------- > > Test set: > > org.apache.maven.execution.DefaultMavenExecutionRequestPopulatorTest > > ------------------------------------------------------------------------------- > > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.002 sec > > <<< FAILURE! - in > > org.apache.maven.execution.DefaultMavenExecutionRequestPopulatorTest > > testPluginRepositoryInjection(org.apache.maven.execution.DefaultMavenExecutionRequestPopulatorTest) > > > > Time elapsed: 0.001 sec <<< ERROR! > > com.google.inject.CreationException: Unable to create injector, see the > > following errors: > > > > 1) null returned by binding at org.eclipse.sisu.wire.LocatorWiring > > but > > org.apache.maven.execution.DefaultMavenExecutionRequestPopulatorTest.testee > > > > is not @Nullable > > while locating org.apache.maven.execution.MavenExecutionRequestPopulator > > for field at > > org.apache.maven.execution.DefaultMavenExecutionRequestPopulatorTest.testee(Unknown > > > > Source) > > at > > org.eclipse.sisu.launch.InjectedTestCase$SetUpModule.configure(InjectedTestCase.java:84) > > > > (via modules: org.eclipse.sisu.wire.WireModule -> > > org.eclipse.sisu.launch.InjectedTestCase$SetUpModule) > > > > 1 error > > at > > com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:448) > > at > > com.google.inject.internal.InternalInjectorCreator.injectDynamically(InternalInjectorCreator.java:176) > > at > > com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:110) > > at com.google.inject.Guice.createInjector(Guice.java:96) > > at com.google.inject.Guice.createInjector(Guice.java:73) > > at com.google.inject.Guice.createInjector(Guice.java:62) > > at > > org.eclipse.sisu.launch.InjectedTestCase.setUp(InjectedTestCase.java:61) > > at junit.framework.TestCase.runBare(TestCase.java:139) > > at junit.framework.TestResult$1.protect(TestResult.java:122) > > at junit.framework.TestResult.runProtected(TestResult.java:142) > > at junit.framework.TestResult.run(TestResult.java:125) > > at junit.framework.TestCase.run(TestCase.java:129) > > at junit.framework.TestSuite.runTest(TestSuite.java:255) > > at junit.framework.TestSuite.run(TestSuite.java:250) > > at > > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) > > at > > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > > at > > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > > at > > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > > at > > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > > at > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) > > at > > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > > > > > > this happens when Maven master/trunk with Maven 3.3.3 > > > > @Stuart, something you can explain? > > > > Robert > > > > > > Op Wed, 16 Sep 2015 09:32:10 +0200 schreef Robert Scholte > > <rfscho...@apache.org (mailto:rfscho...@apache.org)>: > > > > > It was a jigsaw bug, should be fixed with > > > http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/948a1770620e > > > > > > Op Mon, 14 Sep 2015 07:23:17 +0200 schreef Olivier Lamy > > > <ol...@apache.org (mailto:ol...@apache.org)>: > > > > > > > I didn't have a deep look but I guess yes. > > > > > > > > > > > > On 11 September 2015 at 04:43, Robert Scholte <rfscho...@apache.org > > > > (mailto:rfscho...@apache.org)> > > > > wrote: > > > > > > > > > > > > > > https://github.com/codehaus-plexus/plexus-compiler/blob/master/plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavaxToolsCompiler.java > > > > > > > > > > So this file needs to be rewritten, since it is using javax.tools, > > > > > right? > > > > > > > > > > Robert > > > > > > > > > > > > > > > Op Wed, 09 Sep 2015 23:47:46 +0200 schreef Robert Scholte < > > > > > rfscho...@apache.org (mailto:rfscho...@apache.org)>: > > > > > > > > > > Hi, > > > > > > > > > > > > My first results when building Apache Maven 3.3.7-SNAPSHOT > > > > > > Without extra configuration it fails with the message: > > > > > > No compiler is provided in this environment. Perhaps you are > > > > > > running > > > > > > on a > > > > > > JRE rather than a JDK? > > > > > > > > > > > > However, if I add the following arguments it at least continues: > > > > > > -Dmaven.compiler.executable=D:\jdk1.9.0\bin\javac.exe > > > > > > -Dmaven.compiler.fork > > > > > > > > > > > > So this is something we need to fix on our side. If I recall > > > > > > correctly we > > > > > > do a tools.jar check somewhere, will require some extra > > > > > > investigation. > > > > > > > > > > > > The build doesn't complete, it fails with the exception below, but > > > > > > according to the message we need an improved version from ASM first. > > > > > > > > > > > > best, > > > > > > Robert > > > > > > > > > > > > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to > > > > > > execute > > > > > > goal > > > > > > org.codehaus.plexus:plexus-component-metadata:1.5.5:generate-metadata > > > > > > (default) on project maven-model-builder: Error generating metadata: > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216) > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > > > > > > at > > > > > > org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307) > > > > > > at > > > > > > org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193) > > > > > > at > > > > > > org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106) > > > > > > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862) > > > > > > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286) > > > > > > at org.apache.maven.cli.MavenCli.main(MavenCli.java:197) > > > > > > at > > > > > > sun.reflect.NativeMethodAccessorImpl.invoke0(java.base@9.0 > > > > > > (mailto:java.base@9.0)/Native > > > > > > Method) > > > > > > at sun.reflect.NativeMethodAccessorImpl.invoke(java.base@9.0 > > > > > > (mailto:java.base@9.0) > > > > > > /NativeMethodAccessorImpl.java:62) > > > > > > at > > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9.0 > > > > > > (mailto:java.base@9.0) > > > > > > /DelegatingMethodAccessorImpl.java:43) > > > > > > at java.lang.reflect.Method.invoke(java.base@9.0 > > > > > > (mailto:java.base@9.0) > > > > > > /Method.java:517) > > > > > > at > > > > > > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) > > > > > > at > > > > > > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) > > > > > > at > > > > > > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) > > > > > > at > > > > > > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) > > > > > > Caused by: org.apache.maven.plugin.MojoExecutionException: Error > > > > > > generating metadata: > > > > > > at > > > > > > org.codehaus.plexus.maven.plugin.PlexusDescriptorMojo.execute(PlexusDescriptorMojo.java:86) > > > > > > at > > > > > > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) > > > > > > at > > > > > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > > > > > > ... 20 more > > > > > > Caused by: java.lang.Exception: Failed to extract descriptors > > > > > > at > > > > > > org.codehaus.plexus.metadata.DefaultMetadataGenerator.generateDescriptor(DefaultMetadataGenerator.java:86) > > > > > > at > > > > > > org.codehaus.plexus.maven.plugin.PlexusDescriptorMojo.execute(PlexusDescriptorMojo.java:82) > > > > > > ... 22 more > > > > > > Caused by: > > > > > > org.codehaus.plexus.metadata.gleaner.ComponentGleanerException: > > > > > > Can't > > > > > > read > > > > > > class java/lang/Object > > > > > > at > > > > > > org.codehaus.plexus.metadata.gleaner.AnnotationComponentGleaner.readClass2(AnnotationComponentGleaner.java:161) > > > > > > at > > > > > > org.codehaus.plexus.metadata.gleaner.AnnotationComponentGleaner.getClasses(AnnotationComponentGleaner.java:180) > > > > > > at > > > > > > org.codehaus.plexus.metadata.gleaner.AnnotationComponentGleaner.glean(AnnotationComponentGleaner.java:100) > > > > > > at > > > > > > org.codehaus.plexus.metadata.ClassComponentDescriptorExtractor.extract(ClassComponentDescriptorExtractor.java:145) > > > > > > at > > > > > > org.codehaus.plexus.metadata.ClassComponentDescriptorExtractor.extract(ClassComponentDescriptorExtractor.java:79) > > > > > > at > > > > > > org.codehaus.plexus.metadata.DefaultMetadataGenerator.generateDescriptor(DefaultMetadataGenerator.java:78) > > > > > > ... 23 more > > > > > > Caused by: java.io.IOException: Class not found > > > > > > at org.objectweb.asm.ClassReader.a > > > > > > (http://web.asm.ClassReader.a)(Unknown Source) > > > > > > at org.objectweb.asm.ClassReader > > > > > > (http://web.asm.ClassReader).<init>(Unknown Source) > > > > > > at > > > > > > org.codehaus.plexus.metadata.ann.AnnReader.read(AnnReader.java:45) > > > > > > at > > > > > > org.codehaus.plexus.metadata.gleaner.AnnotationComponentGleaner.readClass2(AnnotationComponentGleaner.java:157) > > > > > > ... 28 more > > > > > > > > > > > > > > > > > > > > > > > > Op Wed, 09 Sep 2015 19:16:13 +0200 schreef Rory O'Donnell < > > > > > > rory.odonn...@oracle.com (mailto:rory.odonn...@oracle.com)>: > > > > > > > > > > > > > > > > > > > Hi Robert & Kristian, > > > > > > > > > > > > > > Early-access builds of JDK 9 with Project Jigsaw are available for > > > > > > > download at jdk9.java.net/jigsaw (http://jdk9.java.net/jigsaw) > > > > > > > <http://jdk9.java.net/jigsaw>. > > > > > > > > > > > > > > The EA builds contain the latest prototype implementation of JSR > > > > > > > 376 > > > > > > > <http://openjdk.java.net/projects/jigsaw/spec>, the Java Platform > > > > > > > > > > > > > > Module > > > > > > > System, > > > > > > > as well as that of the JDK-specific APIs and tools described in > > > > > > > JEP > > > > > > > 261 > > > > > > > <http://openjdk.java.net/jeps/261>. > > > > > > > > > > > > > > If you'd like to try out the EA builds, by far the most helpful > > > > > > > things > > > > > > > you can do are: > > > > > > > > > > > > > > * > > > > > > > > > > > > > > Try to run existing applications, without change, on these > > > > > > > builds to > > > > > > > see whether the module system, or the modularization of the > > > > > > > platform, breaks your code or identifies code that depends upon > > > > > > > JDK-internal APIs or other unspecified aspects of the platform. > > > > > > > > > > > > > > * > > > > > > > > > > > > > > Experiment with the module system itself, perhaps by following > > > > > > > the > > > > > > > quick start guide > > > > > > > <http://openjdk.java.net/projects/jigsaw/quick-start>, and start > > > > > > > thinking about how to migrate existing libraries and application > > > > > > > components to modules. We hope to publish some specific migration > > > > > > > tips shortly. > > > > > > > > > > > > > > Please send usage questions and experience reports to the > > > > > > > jigsaw-dev > > > > > > > <http://mail.openjdk.java.net/mailman/listinfo/jigsaw-dev> list. > > > > > > > Specific suggestions about the design of the module system should > > > > > > > be > > > > > > > sent to the JSR 376 Expert Group's comments list > > > > > > > <mailto:jpms-spec-comme...@openjdk.java.net>. > > > > > > > > > > > > > > For more information please seen Mark Reinhold's mail [1] > > > > > > > > > > > > > > Rgds,Rory > > > > > > > > > > > > > > [1] > > > > > > > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2015-September/004480.html > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > > (mailto:dev-unsubscr...@maven.apache.org) > > > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > (mailto:dev-h...@maven.apache.org) > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > (mailto:dev-unsubscr...@maven.apache.org) > > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > (mailto:dev-h...@maven.apache.org) > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > (mailto:dev-unsubscr...@maven.apache.org) > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > (mailto:dev-h...@maven.apache.org) > > > > > > > > > > > > >
