Ok, I fixed the problem in r1703454 Basically I created a method that creates all the symlinks required for the test on the fly, since running on the release on windows would simply not work (it would not create a zip with the proper symlinks since windows subversion does not check out symlinks). This solution is still marginally preferable to dropping windows support entirely :)
K 2015-09-16 10:46 GMT+02:00 Karl Heinz Marbaise <khmarba...@gmx.de>: > Hi Tibor, > > On 9/16/15 9:40 AM, Tibor Digana wrote: >> >> We can release Version 0.10 but the PMC has to then prepare a new >> milestone >> in Jira and migrate these three issues we solved in 0.9. > > Why using 0.10 ? The release can be dropped from Nexus, cause it's a staged > release ...and make Take 2 of the 0.9 release..? > > Kind regards > Karl Heinz Marbaise > >> @Kristian Shall we skip the tests on Windows? This would be the 4th issues >> to fix. >> >> On Wed, Sep 16, 2015 at 9:37 AM, Tibor Digana <tibordig...@apache.org> >> wrote: >> >>> I see ASF builds pass on Linux, but I am using Win with Java 5. >>> That's the reason why symbolic links were skipped because they are Java 7 >>> specific. >>> I am running Java 5 build with [1], and then with Java 7 [2]. I am not >>> authenticated peer with deployment to Maven Central while using Java 5. >>> So yes there are troubles with making the release. >>> I will install Linux, but now I have to spend the time on surefire >>> release >>> till the EO September. >>> >>> [1] mvn release:prepare -DdryRun=true >>> [2] mvn release:prepare -DskipTests >>> >>> >>> >>> On Wed, Sep 16, 2015 at 9:11 AM, Kristian Rosenvold-4 [via Maven] < >>> ml-node+s40175n5844990...@n5.nabble.com> wrote: >>> >>>> Tibor; Which operating system did you use when running the release ? >>>> >>>> I'm probably a bit slow since I'm the last person in the universe to >>>> realize this: Symlinks cannot really be checked into git/svn if we are >>>> to support releases from windows. (If the release is run on >>>> macos/linux it will be ok) >>>> >>>> I assume the file >>>> >>>> >>>> >>> >>> https://svn.apache.org/repos/asf/maven/shared/trunk/src/test/resources/symlinks/src/symR >>>> >>>> >>>> does not become anything symlink-like when you check it out of svn on >>>> windows ? >>>> >>>> Kristian >>>> >>>> >>>> >>>> 2015-09-16 8:45 GMT+02:00 Karl Heinz Marbaise <[hidden email] >>>> <http:///user/SendEmail.jtp?type=node&node=5844990&i=0>>: >>>> >>>>> Hi Tibor, >>>>> >>>>> based on the following i have to give -1... >>>>> >>>>> I have downloaded the source zip and tested with Maven 3.0.5, 3.1.1, >>>> >>>> 3.2.5, >>>>> >>>>> 3.3.3 (via mvn clean verify) on my Mac and got the following in all >>>> >>>> cases... >>>>> >>>>> >>>>> Running org.apache.maven.shared.utils.cli.shell.BourneShellTest >>>>> [/bin/sh, -c, chmod ' ' '|' '&&' '||' ';' ';;' '&' '()' '<' '<<' '>' >>>> >>>> '>>' >>>>> >>>>> '*' '?' '[' ']' '{' '}' '`'] >>>>> /bin/sh -c cd /usr/bin && chmod 'some arg with spaces' >>>>> ---- semi colon tests ---- >>>>> /bin/sh -c cd /usr/bin && chmod ';some&argwithunix$chars' >>>>> [/bin/sh, -c, chmod --password ';password'] >>>>> [[/bin/sh, -c, chmod --password ';password']] >>>>> [[cmd.exe, /X, /C, "--password ;password"]] >>>>> /bin/sh -c cd /usr/bin && chmod 'some arg with spaces' >>>>> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.cli.shell.BourneShellTest >>>>> Running org.apache.maven.shared.utils.ExpandTest >>>>> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.ExpandTest >>>>> Running >>>>> >>> org.apache.maven.shared.utils.introspection.ReflectionValueExtractorTest >>>>> >>>>> Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.048 >>>> >>>> sec - >>>>> >>>>> in >>>> >>>> org.apache.maven.shared.utils.introspection.ReflectionValueExtractorTest >>>>> >>>>> Running org.apache.maven.shared.utils.io.DirectoryScannerTest >>>>> files = [Ljava.lang.String;@7760b68a >>>>> Tests run: 8, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 0.034 >>>> >>>> sec >>>>> >>>>> <<< FAILURE! - in org.apache.maven.shared.utils.io.DirectoryScannerTest >>>>> followSymlinks(org.apache.maven.shared.utils.io.DirectoryScannerTest) >>>> >>>> Time >>>>> >>>>> elapsed: 0.006 sec <<< FAILURE! >>>>> java.lang.AssertionError: null >>>>> at org.junit.Assert.fail(Assert.java:86) >>>>> at org.junit.Assert.assertTrue(Assert.java:41) >>>>> at org.junit.Assert.assertTrue(Assert.java:52) >>>>> at >>>>> >>>> >>> >>> org.apache.maven.shared.utils.io.DirectoryScannerTest.followSymlinks(DirectoryScannerTest.java:179) >>>> >>>> >>>>> >>>>> Running org.apache.maven.shared.utils.io.DirectoryWalkerTest >>>>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.io.DirectoryWalkerTest >>>>> Running org.apache.maven.shared.utils.io.FileUtilsTest >>>>> Tests run: 89, Failures: 1, Errors: 0, Skipped: 24, Time elapsed: 0.171 >>>> >>>> sec >>>>> >>>>> <<< FAILURE! - in org.apache.maven.shared.utils.io.FileUtilsTest >>>>> copyFileThatIsSymlink(org.apache.maven.shared.utils.io.FileUtilsTest) >>>> >>>> Time >>>>> >>>>> elapsed: 0.003 sec <<< FAILURE! >>>>> java.lang.AssertionError: null >>>>> at org.junit.Assert.fail(Assert.java:86) >>>>> at org.junit.Assert.assertTrue(Assert.java:41) >>>>> at org.junit.Assert.assertTrue(Assert.java:52) >>>>> at >>>>> >>>> >>> >>> org.apache.maven.shared.utils.io.FileUtilsTest.copyFileThatIsSymlink(FileUtilsTest.java:433) >>>> >>>> >>>>> >>>>> Running org.apache.maven.shared.utils.io.IOUtilTest >>>>> Tests run: 353, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.18 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.io.IOUtilTest >>>>> Running org.apache.maven.shared.utils.io.Java7SupportTest >>>>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - >>>> >>>> in >>>>> >>>>> org.apache.maven.shared.utils.io.Java7SupportTest >>>>> Running org.apache.maven.shared.utils.io.MatchPatternsTest >>>>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.io.MatchPatternsTest >>>>> Running org.apache.maven.shared.utils.io.MatchPatternTest >>>>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - >>>> >>>> in >>>>> >>>>> org.apache.maven.shared.utils.io.MatchPatternTest >>>>> Running org.apache.maven.shared.utils.io.SelectorUtilsTest >>>>> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - >>>> >>>> in >>>>> >>>>> org.apache.maven.shared.utils.io.SelectorUtilsTest >>>>> Running org.apache.maven.shared.utils.OsTest >>>>> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.OsTest >>>>> Running org.apache.maven.shared.utils.PathToolTest >>>>> Tests run: 4, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - >>>> >>>> in >>>>> >>>>> org.apache.maven.shared.utils.PathToolTest >>>>> Running org.apache.maven.shared.utils.PropertyUtilsTest >>>>> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.PropertyUtilsTest >>>>> Running org.apache.maven.shared.utils.reflection.ReflectorTest >>>>> Tests run: 124, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.041 >>>> >>>> sec >>>>> >>>>> - in org.apache.maven.shared.utils.reflection.ReflectorTest >>>>> Running org.apache.maven.shared.utils.StringUtilsTest >>>>> Tests run: 162, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.082 >>>> >>>> sec >>>>> >>>>> - in org.apache.maven.shared.utils.StringUtilsTest >>>>> Running org.apache.maven.shared.utils.xml.PrettyPrintXmlWriterTest >>>>> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.xml.PrettyPrintXmlWriterTest >>>>> Running org.apache.maven.shared.utils.xml.pull.Xpp3DomTest >>>>> Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.028 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.xml.pull.Xpp3DomTest >>>>> Running org.apache.maven.shared.utils.xml.XmlWriterUtilTest >>>>> output = >>>>> x >>>>> Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.xml.XmlWriterUtilTest >>>>> Running org.apache.maven.shared.utils.xml.Xpp3DomBuilderTest >>>>> [Fatal Error] :11:1: XML document structures must start and end within >>>> >>>> the >>>>> >>>>> same entity. >>>>> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.xml.Xpp3DomBuilderTest >>>>> Running org.apache.maven.shared.utils.XmlStreamReaderTest >>>>> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 >>>> >>>> sec - >>>>> >>>>> in org.apache.maven.shared.utils.XmlStreamReaderTest >>>>> >>>>> Results : >>>>> >>>>> Failed tests: >>>>> DirectoryScannerTest.followSymlinks:179 null >>>>> FileUtilsTest.copyFileThatIsSymlink:433 null >>>>> >>>>> Tests run: 858, Failures: 2, Errors: 0, Skipped: 27 >>>>> >>>>> [INFO] -------------------------------------------------------- >>>>> >>>>> This is my environment: >>>>> >>>>> ~/Downloads/maven-shared-utils-0.9$ mvn --version >>>>> Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; >>>>> 2015-04-22T13:57:37+02:00) >>>>> Maven home: /usr/share/maven >>>>> Java version: 1.7.0_21, vendor: Oracle Corporation >>>>> Java home: >>>>> /Library/Java/JavaVirtualMachines/jdk1.7.0_21.jdk/Contents/Home/jre >>>>> Default locale: en_US, platform encoding: UTF-8 >>>>> OS name: "mac os x", version: "10.8.5", arch: "x86_64", family: "mac" >>>>> >>>>> >>>>> >>>>> >>>>> On 9/15/15 11:22 PM, Tibor Digana wrote: >>>>>> >>>>>> >>>>>> Hi, >>>>>> >>>>>> We solved 3 issues: >>>>>> >>>>>> >>>> >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12332813 >>>>>> >>>>>> >>>>>> There are still a couple of issues left in JIRA: >>>>>> >>>>>> >>>> >>> >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-shared-utils%20ORDER%20BY%20priority%20DESC >>>>>> >>>>>> >>>>>> Staging repo: >>>>>> https://repository.apache.org/content/repositories/maven-1209/ >>>>>> >>>>>> >>>>>> >>>> >>> >>> https://repository.apache.org/content/repositories/maven-1209/org/apache/maven/shared/maven-shared-utils/0.9/maven-shared-utils-0.9-source-release.zip >>>>>> >>>>>> >>>>>> Source release checksum(s): >>>>>> maven-shared-utils-0.9-source-release.zip sha1: >>>>>> d22561a99867a29552972c459fee82de3f255949 >>>>>> >>>>>> Staging site: >>>>>> >>>>>> >>>> >>> >>> https://svn.apache.org/repos/infra/websites/production/maven/components/shared-archives/maven-shared-utils-LATEST >>>>>> >>>>>> >>>>>> Guide to testing staged releases: >>>>>> >>> http://maven.apache.org/guides/development/guide-testing-releases.html >>>>>> >>>>>> >>>>>> Vote open for 72 hours. >>>>>> >>>>>> [ ] +1 >>>>>> [ ] +0 >>>>>> [ ] -1 >>>>>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
