Github user marob commented on the pull request:

    https://github.com/apache/maven-wagon/pull/16#issuecomment-141702559
  
    As you can see, my modifications are in the 
AbstractJschWagon.openConnectionInternal method. This method launches a real 
connection and cannot be easily tested.
    For example, it contains the following line (that instantiates a real JSch 
instance that is not mockable):
    ```java
    JSch sch = new JSch();
    ```
    
    Some important refactoring would be required to make it testable.
    
    Nevertheless, I've built a POC at https://github.com/marob/maven-wagon-426 
to demonstrate the bug and my fix.
    Please, take the time to test my POC.
    
    Regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to