Based on code review I found a large number of close-statements that were not in the mandated finally blocks, which would create resource leakage on kill.
I fixed this in bb99b232da0e93f2772be6945a410ea9ba666c4f, hope this will help the situation on windows. Kristian 2015-10-23 17:26 GMT+02:00 Tibor Digana <[email protected]>: > The infra team made a cleaup of Jenkins workspace which really helped once. > Next time I triggered the build we got same symptoms as before: > > FATAL: Command "git clean -fdx" returned status code 1: > stdout: Removing maven-failsafe-plugin/target/ > stderr: warning: failed to remove surefire-integration-tests/target/ > > It looks like we have some files in test which leak. Therefore I asked > Gavin [1] to find out those files which are held by a process. > [1] https://issues.apache.org/jira/browse/INFRA-10650 > > > > > On Fri, Oct 23, 2015 at 6:23 AM, Kristian Rosenvold-4 [via Maven] < > [email protected]> wrote: > >> (Tibor; I'm taking this to the mailing list) >> >> >> It would appear that we are leaking file handles/resources when being >> killed by jenkins. This is not entirely surprising, since this is >> notoriously hard to get right. Does anyone know how the timeout in >> jenkins kills our process ? (If it's the equivalent of kill -9 we're >> in trouble no matter what, but usually some softer means is used >> first....) >> >> I'll montor for resurce leaks while killing processes this weekend to >> see if I can find anything. >> >> Kristian >> >> >> >> ---------- Forwarded message ---------- >> From: Tibor Digana <[hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5850011&i=0>> >> Date: 2015-10-22 21:05 GMT+02:00 >> Subject: Re: to delete windows build ? >> To: Andreas Gudian <[hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5850011&i=1>> >> Kopi: Kristian Rosenvold <[hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5850011&i=2>> >> >> >> >>Could it be the ancient shadefire-version that causes hanging processes >> in our integration tests on those windows nodes? >> I do not know since I could not reproduce this issue on my system. >> >> IMHO the files are locked after the job has timed out. My words in JIRA: >> "The build setup says that the build timeout is 69 min. The bild was >> running 64 which is very close." >> >> I should reopen the bug and ask INFRA to clean up the workspace. >> >> I expected INFRA to find out the root cause. The time out issue is a >> guess. >> >> Cheers >> Tibor >> >> On Thu, Oct 22, 2015 at 6:12 PM, Andreas Gudian >> <[hidden email] <http:///user/SendEmail.jtp?type=node&node=5850011&i=3>> >> wrote: >> >> > >> > Hi, >> > >> > A build that fails constantly has no value at all. A working Windows >> build on the other hand would be something that I'd consider quite >> important - process spawning, communication and termination can behave >> slightly different under different OS's. >> > >> > Tibor and I are on Windows, but if someone else working on OSX or Linux >> starts changing something in that area, the missing Windows builds (or the >> currently unusable jobs) could create a blind spot. >> > >> > Could it be the ancient shadefire-version that causes hanging processes >> in our integration tests on those windows nodes? I never had any problems >> with it on my local machines, though. >> > >> > Cheers, >> > Andreas >> > >> > >> > Am Donnerstag, 22. Oktober 2015 schrieb Tibor Digana : >> >> >> >> Hi, >> >> >> >> Our CI build permanently fails due to locked files in workspace. >> >> https://builds.apache.org/job/maven-surefire-windows/ >> >> I reported an issue but this did not help >> https://issues.apache.org/jira/browse/INFRA-10547 >> >> Do we need Windows build? >> >> It looks like there is only Windows1 and Windows2 machine. One is too >> slow and the next one has this problem with file system. >> >> I prefer working Win agent but the INFRA does not care. >> >> >> >> -- >> >> Cheers >> >> Tibor >> >> >> >> >> -- >> Cheers >> Tibor >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5850011&i=4> >> For additional commands, e-mail: [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5850011&i=5> >> >> >> >> ------------------------------ >> If you reply to this email, your message will be added to the discussion >> below: >> http://maven.40175.n5.nabble.com/Fwd-to-delete-windows-build-tp5850011.html >> To start a new topic under Maven Developers, email >> [email protected] >> To unsubscribe from Maven Developers, click here >> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==> >> . >> NAML >> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> >> > > > > > -- > View this message in context: > http://maven.40175.n5.nabble.com/Fwd-to-delete-windows-build-tp5850011p5850043.html > Sent from the Maven Developers mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
