if there is a regression, why not just open a Jira issue and fix it? I had a look at code, and it seems there is not any unit test against default version policy
Regards, Hervé Le samedi 31 octobre 2015 17:41:45 Stephen Connolly a écrit : > On Saturday 31 October 2015, Hervé BOUTEMY <[email protected]> wrote: > > I don't know what "Cloudbees conventions" are, and how they are superior > > to > > everything else = what I understand from the README > > I jusj had to put a readme quickly. > > It is basically increment the least significant segment (which is what the > release plugin *used* to do) I added some extra bits like if the last > segment is -alpha then that goes to -beta-1 and -beta goes to -rc-1 > > In any case if moving the code to ASF I would be removing the CloudBees > references > > > if we were able to better describe this policy, and compare different > > policies, > > that would give a meaning to adding more and providing them by default in > > the > > plugin to let users configure in the plugin policy to match the effective > > convention they use > > > > So, as the code currently says "cloudbees convention" without saying what > > it > > is, but just that it fixes everything (which is an assertion I can't > > trust), I > > don't see the point in integrating it in the plugin > > > > but I see the interest in adding more version policies, describing them in > > a > > neutral way (= strictly what they do), to let end users choose an > > implementation matching their need (ie their effective convention) > > > > Regards, > > > > Hervé > > > > Le vendredi 30 octobre 2015 12:16:35 Stephen Connolly a écrit : > > > Hey, so... > > > > > Do we want to accept this implementation I knocked together: > > https://github.com/CloudBees-community/cloudbees-maven-release-version-pol > > ic> > > > y > > > > > > If not I'm fine leaving it where it is... but I can get it donated to > > > the ASF if there is interest > > > > > > -Stephen > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] <javascript:;> > > > For additional commands, e-mail: [email protected] > > > > <javascript:;> > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] <javascript:;> > > For additional commands, e-mail: [email protected] <javascript:;> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
