GitHub user mstanleyjones opened a pull request:

    https://github.com/apache/maven-skins/pull/4

    Hamburger menu with top-nav only

    In 1.4 and 1-5-SNAPSHOT, the theme does not add the hamburger menu elements 
unless the sidebar is enabled. This patch addresses that. I tested locally 
after running 'mvn install'. You can see the bug at 
http://mstanleyjones.github.io/hbase/, which is missing the following bit of 
code:
    ````
    <a data-target=".nav-collapse" data-toggle="collapse" class="btn btn-navbar 
collapsed">
       <span class="icon-bar"></span>
       <span class="icon-bar"></span>
       <span class="icon-bar"></span>
    </a>
    ````
    
    I believe the patch should backport cleanly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mstanleyjones/maven-skins trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-skins/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit f559695b03826158eb302e60b40d4924f28a8bf4
Author: Misty Stanley-Jones <[email protected]>
Date:   2015-11-09T03:19:56Z

    Make the hamburger menu work with the top-navigation enabled and 
sidebar-navigation disabled

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to