Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/107#issuecomment-160474911
Current status:
5.14.3
-------
The jar is still available:
https://github.com/cbeust/testng/blob/master/lib-supplied/guice-2.0.jar
It's a shaded jar of Guice 2.0 with custom package. Its usage was removed
in 5.14.6 with
https://github.com/cbeust/testng/commit/331ab5267015b500bd06204f8c2c9cde40dc2e40
> We can add system-dependency to the pom.xml of IT
I think the pom will still be wrong for 5.14.3 and maven will ignore
transitive dependencies.
It could work for 5.14.4 and 5.14.5, but the 5.14.4 test seems to work
without this jar.
> you can of course ask Cedric how the users use to struggle with this
problem.
I supposed they don't: 5.14.6 and later replaced previous 5.14.x, and there
is no more support on so old versions.
But maybe @cbeust can tell us the story of this shaded jar :)
5.13 & 5.14.2
-------
Fun part for the listener attribute:
* Before -> ?
* 5.12.1 -> List<Class>
* 5.13 / 5.13.1 / 5.14 -> String
* 5.14.1 / 5.14.2 -> List
* 5.14.3 until now -> Both (String or List) is possible
But, even fixed, there is an issue in TestNG with listener:
Join on `<space>` ->
https://github.com/cbeust/testng/blob/testng-5.14.2/src/main/java/org/testng/TestNG.java#L1313
And split on `,` or `;` ->
https://github.com/cbeust/testng/blob/testng-5.14.2/src/main/java/org/testng/TestNG.java#L1178
Fixed with 5.14.3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
