Right, there is no IT in m-jar-plugun to check this. The tests are in the library/component that handles this.
/Anders (mobile) On May 7, 2016 23:06, "Robert Scholte" <rfscho...@apache.org> wrote: > I'm using Win10 > > The funny thing: > Manifest-Version: 1.0 > Implementation-Vendor: The Apache Software Foundation > Implementation-Title: Apache Maven JAR Plugin > Implementation-Version: 3.0.0 > Implementation-Vendor-Id: org.apache.maven.plugins > Built-By: Robert Scholte > Build-Jdk: 1.7.0_55 > Specification-Vendor: The Apache Software Foundation > Specification-Title: Apache Maven JAR Plugin > Created-By: Apache Maven 3.3.9 > Specification-Version: 3.0.0 > Archiver-Version: Plexus Archiver > > So the version is set correctly in the plugin jar. > > At least one IT-project should have failed because of the missing version, > so it seems there was no additional IT written to check the value of > Created-By: > > Where should this maven.version come from? > > Robert > > On Sat, 07 May 2016 22:54:34 +0200, Karl Heinz Marbaise <khmarba...@gmx.de> > wrote: > > Hi Robert, >> >> On 5/7/16 10:24 PM, Robert Scholte wrote: >> >>> This is my content of >>> >>> maven-jar-plugin-3.0.0\target\it\manifest-content\target\manifest-content-1.0-SNAPSHOT.jar!/META-INF/MANIFEST.MF >>> >>> >>> Manifest-Version: 1.0 >>> Implementation-Vendor: jar plugin it >>> Implementation-Title: manifest-content-it >>> Implementation-Version: 1.0-SNAPSHOT >>> Implementation-Vendor-Id: org.apache.maven.plugins >>> Built-By: Robert Scholte >>> Build-Jdk: 1.7.0_55 >>> Specification-Vendor: jar plugin it >>> Specification-Title: manifest-content-it >>> Created-By: Apache Maven >>> Specification-Version: 1.0 >>> Main-Class: myproject.HelloWorld >>> Archiver-Version: Plexus Archiver >>> >>> build.log show >>> [DEBUG] Populating class realm >>> plugin>org.apache.maven.plugins:maven-jar-plugin:3.0.0 >>> [DEBUG] Included: org.apache.maven.plugins:maven-jar-plugin:jar:3.0.0 >>> [DEBUG] Included: org.sonatype.sisu:sisu-inject-bean:jar:1.4.2 >>> [DEBUG] Included: org.sonatype.sisu:sisu-guice:jar:noaop:2.1.7 >>> [DEBUG] Included: org.sonatype.aether:aether-util:jar:1.7 >>> [DEBUG] Included: org.codehaus.plexus:plexus-interpolation:jar:1.14 >>> [DEBUG] Included: >>> org.codehaus.plexus:plexus-component-annotations:jar:1.5.5 >>> [DEBUG] Included: org.sonatype.plexus:plexus-sec-dispatcher:jar:1.3 >>> [DEBUG] Included: org.sonatype.plexus:plexus-cipher:jar:1.4 >>> [DEBUG] Included: org.apache.maven:maven-archiver:jar:3.0.2 >>> [DEBUG] Included: org.apache.maven.shared:maven-shared-utils:jar:3.0.0 >>> [DEBUG] Included: commons-io:commons-io:jar:2.4 >>> [DEBUG] Included: com.google.code.findbugs:jsr305:jar:2.0.1 >>> [DEBUG] Included: org.codehaus.plexus:plexus-archiver:jar:3.1.1 >>> [DEBUG] Included: org.codehaus.plexus:plexus-io:jar:2.7.1 >>> [DEBUG] Included: org.apache.commons:commons-compress:jar:1.10 >>> [DEBUG] Included: org.iq80.snappy:snappy:jar:0.4 >>> [DEBUG] Included: org.codehaus.plexus:plexus-utils:jar:3.0.22 >>> >> >> Hm...the list is exactly the same i have here on Mac OS.... >> so the components are there...so only the behaviour in the components can >> make the difference... >> >> So i have tested on Windows XP with Maven 3.2.1 and 3.3.9 and it works >> correctly... >> >> Manifest-Version: 1.0 >> Implementation-Vendor: jar plugin it >> Implementation-Title: manifest-content-it >> Implementation-Version: 1.0-SNAPSHOT >> Implementation-Vendor-Id: org.apache.maven.plugins >> Built-By: kama >> Build-Jdk: 1.7.0_55 >> Specification-Vendor: jar plugin it >> Specification-Title: manifest-content-it >> Created-By: Apache Maven 3.3.9 >> Specification-Version: 1.0 >> Main-Class: myproject.HelloWorld >> Archiver-Version: Plexus Archiver >> >> >> Hm... >> >> >> >> >> >> >> >>> I haven't installed the plugin in my repository. >>> >>> Could it be a Windows issue? >>> >>> Robert >>> >>> On Sat, 07 May 2016 21:04:19 +0200, Karl Heinz Marbaise >>> <khmarba...@gmx.de> wrote: >>> >>> Hi Robert, >>>> >>>> On 5/7/16 8:35 PM, Robert Scholte wrote: >>>> >>>>> https://issues.apache.org/jira/browse/MJAR-218 >>>>> is this really fixed? >>>>> >>>>> I still see a versionless Apache Maven in the MANIFEST.MF >>>>> >>>> >>>> Hm...I tested with Maven 3.0.5 and 3.3.9 via >>>> >>>> mvn -Prun-its clean verify >>>> >>>> and checked the generated JAR files which are Ok.... >>>> >>>> Furthermore i run Maven 3.3.9 and also: >>>> >>>> mvn -Prun-its clean verify >>>> -Dinvoker.mavenHome=/usr/share/java/apache-maven-3.0.5 >>>> >>>> which produces correct artifacts >>>> >>>> >>>> Unfortunately i can not reproduce this at the moment...But it if is >>>> not..So it means making a 3.0.1 release very soon... >>>> >>>> Can you give some examples of files which do not contain the correct: >>>> "Created-By: " entry? >>>> >>>> Kind regards >>>> Karl Heinz Marbaise >>>> >>>> >>>> >>>> >>>>> Executed as >>>>> d:\apache-maven-3.3.9\bin\mvn clean verify -Prun-its >>>>> -Dinvoker.mavenHome=d:\apache-maven-3.0 >>>>> >>>>> thanks, >>>>> Robert >>>>> >>>>> On Wed, 04 May 2016 20:16:20 +0200, Karl Heinz Marbaise >>>>> <khmarba...@gmx.de> wrote: >>>>> >>>>> Hi, >>>>>> >>>>>> We solved 21 issues: >>>>>> >>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12334171 >>>>>> >>>>>> >>>>>> >>>>>> There are still a couple of issues left in JIRA: >>>>>> >>>>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MJAR%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC >>>>>> >>>>>> >>>>>> >>>>>> Staging repo: >>>>>> https://repository.apache.org/content/repositories/maven-1265 >>>>>> >>>>>> https://repository.apache.org/content/repositories/maven-1265/org/apache/maven/plugins/maven-jar-plugin/3.0.0/maven-jar-plugin-3.0.0-source-release.zip >>>>>> >>>>>> >>>>>> >>>>>> Source release checksum(s): >>>>>> maven-jar-plugin-3.0.0-source-release.zip sha1: >>>>>> b749bfd9e76b92102f372fd807b17779c4d03c7e >>>>>> >>>>>> Staging site: >>>>>> http://maven.apache.org/plugins-archives/maven-jar-plugin-LATEST/ >>>>>> >>>>>> Guide to testing staged releases: >>>>>> http://maven.apache.org/guides/development/guide-testing-releases.html >>>>>> >>>>>> Vote open for 72 hours. >>>>>> >>>>>> [ ] +1 >>>>>> [ ] +0 >>>>>> [ ] -1 >>>>>> >>>>>> Kind regards >>>>>> Karl Heinz Marbaise >>>>>> >>>>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >>> >>> >> >> Mit freundlichem Gruß >> Karl-Heinz Marbaise >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
