Hi Robert,

For the skip parameter, the test is very simple. Usage of the fix goal without disabling CLIRR will result in a loop where fix invokes clirr, and clirr runs fix.

I understand your reticence about this skip option - but in scenarios where one wants to have the plugin execute automatically with "force", having an override is useful. So from my perspective it is useful and it follows the patterns that other plugins use, including the javadoc plugin - just this goal is missing a skip option.

I didn't break the patch up into smaller patches, but I did annotate all of the changes that the patch performs line-by-line in the Jira case. I hope that helps "demystify" the fixes.

Best regards,

Richard

Robert Scholte <mailto:rfscho...@apache.org>
June 8, 2016 at 2:01 PM
Hi Richard,

this release is to push the final 2.x version before moving to a pure Maven 3 implementation (there were quite some fixed issues waiting to be released). Once released I will continue, also including some Java9 related improvements. That will give me enough time to go through your patches. Since you weren't able to split it into smaller pieces I need more time to verify and apply it.

thanks,
Robert

ps. In case you are still convinced the skip parameter is required, you need a complete testcase to show it to me. In general *I* won't apply any requests to add a skip parameter, there are often better solutions.

On Wed, 08 Jun 2016 00:53:33 +0200, Richard Sand <rs...@idfconnect.com> wrote:


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Richard Sand <mailto:rs...@idfconnect.com>
June 7, 2016 at 6:53 PM
The patch I supplied for MJAVADOC-452, 451, 434 and 420 won't be considered for inclusion? I can recreate the patch off of the latest trunk if it would help

Best regards,

Richard




Sent from my iPhone

Reply via email to