Hi,

On 6/12/16 3:10 PM, Christian Schulte wrote:
Am 06/12/16 um 15:01 schrieb Robert Scholte:
Based on the description "Make 'optional' flag of a dependency manageable"
I would say -1 for this change.

Why?

At the moment (I'm not sure about this) is that this change is changing behaviour in relationship to test scope dependencies which breaks builds in comparsion to Maven 3.3.X and before...

That's why Robert says -1 ...

We need to clarify if this is related to this change or not...or do we have other changes which can cause this...so we need to identify this...




Or is this the answer to global excludes?

It can be used to exclude a dependency globally by flagging it optional
in dependency management.

Maybe the description is misleading, because IIRC this is more about
transitive dependencies which were marked as optional. Those dependencies
should not end up in the resolution.

No. It's about allowing to manage the optional flag the same way the
scope and version can be managed. What's wrong with that? It's a missing
feature.

Yes managing the optional flag is one thing but based on the code examples you have given in the issue it looks like it influences the test scope dependencies as well cause it's mentioned with "provided" scope...




Give Christian Schulte the chance to clarify this again, based on 2 or 3
poms. Hopefully that explains it a bit more. Issue has reached TLDR status.

What is there I need to clarify?


We need to check if this issue is causing those problems? (See users list)...

After checking git history: Based on the code changes which are related to the issue MNG-5227 it is only related to managing optional flag. And not about test transitivity...So this means there is an other change which caused the change in behaviour...

Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to