To be honest I dont think it would be a problem if it were in core. Easier to understand for plugin developers potentially and a good motivation for users to upgrade as well as plugin developers to move forward..
Manfred Karl Heinz Marbaise wrote on 2016-07-04 10:38: > Hi, > > On 7/4/16 6:52 PM, Christian Schulte wrote: >> Am 07/04/16 um 16:57 schrieb Hervé BOUTEMY: >>> Hi, >>> >>> To me, color is now feature complete: configuration has been added in >>> r1751085 >>> (thanks Sébastian), for those wanting to customize their own personal color >>> scheme. >>> >>> There is now only one issue: where to put the code? >>> It is currently in maven-shared-utils, but maven-shared-utils depends on >>> maven-core (for toolchains): see MSHARED-567 >>> >>> Should we remove the dependency? Should we move the code to another place? >> >> We have >> >> maven-model >> maven-model-builder >> maven-settings >> maven-settings-builder >> >> Would >> >> maven-toolchains >> maven-toolchains-builder >> >> or something like this solve the issue or would it be the same as >> depending on maven-core? So the issue is that toolchains is located >> somewhere inappropriately, correct? Maybe move toolchains into >> maven-shared-utils or make it something standalone @shared? We can >> deprecate toolchains in maven-core 3.4 easily and move it somewhere else. >> >> Regards, >> > > > I think the idea to make a separate shared component > maven-shared-toolchains ...and deprecated it in Maven Core...putting > into maven-shared-utils sounds wrong... > > Kind regards > Karl Heinz Marbaise > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
