After digging a bit deeper, org.apache.maven.plugin.issues.Issue#getTitle is only referenced in the changed GitHubDownloaderTestCase.
I changed the getter visibility to private (only test I had to adapt was above GHDTC) and ran 'mvn -Prun-its clean verify' without issue. In GH you may set a description for milestones (which have a title, often used for version numbers), in JIRA you have fixVersions which have a name (often used for version numbers) and a description. We could probably just drop the issue title, but this would be a breaking change, so I do not know wether it is worth it. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/ On Sat, Jul 9, 2016 at 11:41 AM, Mirko Friedenhagen <[email protected]> wrote: > Hello Robert, > > firstly I just resurrected the state as it was before. The current > changes-plugin-release does not output the "title" of GH issues > anymore but the complete body which is not useable in a tabular > output. > > I am a bit afraid, that there is a mismatch between JIRA and GitHub > here. JIRA's summary is called title in GitHub. > > JIRA: > https://issues.apache.org/jira/rest/api/2/issue/MCHANGES-371?fields=summary,description > GH: https://api.github.com/repos/mojohaus/versions-maven-plugin/issues/95 > > So we have: > GitHub title corresponds to JIRA summary > GitHub body corresponds to JIRA description > > I will take another look. > Regards Mirko > -- > http://illegalstateexception.blogspot.com/ > https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) > https://bitbucket.org/mfriedenhagen/ > > > On Wed, Jul 6, 2016 at 6:43 PM, Robert Scholte <[email protected]> wrote: >> On Tue, 05 Jul 2016 22:47:33 +0200, <[email protected]> wrote: >> >>> assertEquals( githubIssue.getTitle(), issue.getTitle() ); >>> - assertEquals( githubIssue.getBody(), issue.getSummary() ); >>> + assertEquals( githubIssue.getTitle(), issue.getSummary() ); >> >> >> This looks weird to me: this can only be true in issue.getTitle() and >> issue.getSummary() are the same. >> Are you sure that the problem is here and not in the report? >> >> Robert >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
