Hi Hervé,

This will already break backwards compatibility because the signature has changed. In other words: projects using this method need to be recompiled; they can't simply switch to this version.
So is it worth keeping this piece of code here?

Robert


On Sat, 09 Jul 2016 00:32:00 +0200, <[email protected]> wrote:

--- maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/cli/javatool/JavaTool.java (original) +++ maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/cli/javatool/JavaTool.java Fri Jul 8 22:32:00 2016
@@ -19,8 +19,6 @@ package org.apache.maven.shared.utils.cl
  * under the License.
  */
-import org.apache.maven.toolchain.Toolchain;
-
 /**
  * Describes a java tool, means a executable available in the jdk.
  * <p/>
@@ -51,8 +49,10 @@ public interface JavaTool<Request extend
* Set an optional tool chain to find out the java tool executable location.
      *
* @param toolchain optional tool chain to find out the java tool executable location. + * To avoid direct dependency on Maven core, this parameter is an Object that will be
+     * used as Toolchain through reflection
      */
-    void setToolchain( Toolchain toolchain );
+    void setToolchain( Object toolchain );
    /**
* Execute the input request and then returns the result of the execution.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to