Github user britter commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/120#discussion_r78775898
  
    --- Diff: 
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
 ---
    @@ -159,4 +164,10 @@ public static IntegrationTestSuiteResults 
parseReportList( List<ReportTestSuite>
                 throw new RuntimeException( "Couldn't parse XML reports", e );
             }
         }
    +
    +    public static void assumeJavaVersion(JavaVersion version)
    +    {
    +        assumeThat( "java.specification.version: ",
    --- End diff --
    
    Hey Tibor,
    
    do you mean to use a constant instead of the string in the message part of 
`assumeThat`? There is no constant for the property name in Commons Lang. But I 
could introduce one in `HelperAssertions` or we could extend SystemUtils, but 
then we have to wait for the next release of Commons Lang.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to