i find throwing everything in the kitchen sink and hoping all the dishes get cleaned doesnt workpick one variable such as maven-plugin-plugin and introduce each new version by a point release3.0 causes exception3.1 causes exception...3.5 works with asm6 and JDK 1.9 eventually you'll determine which version works with your specific environment configuration
ToDo: can someone update README for 3.5 that 3.5 works with JDK1.9 and ASM6? thanks romainMartin ______________________________________________ > From: rmannibu...@gmail.com > Date: Mon, 10 Oct 2016 21:04:50 +0200 > Subject: RE: upgrade maven plugin to run with asm 6? > To: dev@maven.apache.org > > Oh tested 3.4 but missed 3.5. 3.5 solved the issue! > > Thanks! > > Le 10 oct. 2016 20:31, "Martin Gainty" <mgai...@hotmail.com> a écrit : > > > > > > > > > > > From: rmannibu...@gmail.com > > > Date: Mon, 10 Oct 2016 17:07:54 +0200 > > > Subject: Re: upgrade maven plugin to run with asm 6? > > > To: dev@maven.apache.org > > > > > > 2016-10-10 16:54 GMT+02:00 Martin Gainty <mgai...@hotmail.com>: > > > > > > > > > > > > > > > > > > > > From: rmannibu...@gmail.com > > > > > Date: Mon, 10 Oct 2016 15:10:33 +0200 > > > > > Subject: upgrade maven plugin to run with asm 6? > > > > > To: dev@maven.apache.org > > > > > > > > > > Hi guys, > > > > > > > > > > is there some plans to upgrade maven plugin to asm6 (thinking > > > > > to maven-plugin-tools-annotations and maven-plugin-plugin and more > > > > > concretely to DefaultMojoAnnotationsScanner used to generate the > help > > > > mojo)? > > > > > > > > > > I know there is only the alpha our ATM but I think it would enable > users > > > > to > > > > > start building using asm 6 instead of preventing them to run their > build > > > > > and the later upgrade would be smooth. > > > > MG>craft a q&d test-harness > > > > MG>switch JAVA to JDK 1.8 > > > > MG>in test-harness substitute in asm-6 into dependency-management of > > > > parent pom > > > > MG>mvn package and observe: > > > > MG>ANY TEST ERRORS ? > > > > MG>ANY TEST FAILURES? > > > > MG>is JDKProxy being implemented to implement Interfaces? > > > > MG>is asm-6 being called to extend subclasses? > > > > MG>http://stackoverflow.com/questions/10664182/what-is- > > > > the-difference-between-jdk-dynamic-proxy-and-cglib > > > > MG>if all of these scenarios pass I think you will have a *convincing > > > > case* to upgrade asm to 6 in all plugins > > > > MG>I have a few spare cycles today so let me know if you need any > > > > assistance > > > > > > > > > > > so concretely I wanted to upgrade > > > https://github.com/tomitribe/crest/tree/master/crest-maven-plugin to > asm6 > > > to support java 9 (not sure why you spoke of java 8, typo?) but the side > > > effect of upgrading it as a dependency of my project was to break the > > > maven-plugin-plugin. I'm not sure why isolation was broken but I'm very > > > concerned cause soon we'll upgrade the whole tomee stack to asm 6 > (xbean, > > > openjpa, cxf, openwebbeans, batchee, tomee itself and probably a few I > > > forget) and most of them have maven plugins and would break. > > > > > > It fails with a NPE in Type.getProxyClass IIRC so maven annotation > scanner > > > doesn't work on java 9. > > MG>JDK 1.9 annotation processor has been "tweaked" > > MG>http://openjdk.java.net/jeps/217 > > MG>which is the reason why I suggested using the older annotation scanner > > MG>do we know if error originates from ASM6 upgrade, maven-plugin or > JDK1.9 that said can you post a bug in JIRA? > > MG>https://maven.apache.org/issue-tracking.html > > > > > > Will be a bit short to help in the ~2 coming weeks but if nothing moved > > > next month I'll try to hack something up for sure! > > > > > > > > > > > > > > > > > > > > Romain Manni-Bucau > > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog > > > > > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > > > > rmannibucau> | > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > > > > > <http://www.tomitribe.com> | JavaEE Factory > > > > > <https://javaeefactory-rmannibucau.rhcloud.com> > > > > > >
