Am 2016-12-28 um 21:34 schrieb Guillaume Boué:
I have the same results as Hervé, both on Windows and Ubuntu. This is
what I have with Maven 3.3.9:
- Windows 10 64bit, OpenJDK 1.8.0_102, Test failure: Timeout in
HugeFileDownloadTest (perhaps the timeout should be increased?)
How often did you run the tests to get this result? I tried at least 20
times or more.
Can you enable the logging I asked Dan for? You might see something else.
By timeout do you mean the timeout Surefire waits for the forked VM?
Can you try the attached patch? I have noticed that in this
HugeFileDownloadTest the server is never shutdown as well as in other cases.
Michael
diff --git
a/wagon-provider-test/src/main/java/org/apache/maven/wagon/http/HttpWagonTestCase.java
b/wagon-provider-test/src/main/java/org/apache/maven/wagon/http/HttpWagonTestCase.java
index 172d5be..c19eaa3 100644
---
a/wagon-provider-test/src/main/java/org/apache/maven/wagon/http/HttpWagonTestCase.java
+++
b/wagon-provider-test/src/main/java/org/apache/maven/wagon/http/HttpWagonTestCase.java
@@ -715,6 +715,7 @@ public void testRedirectGetToStream()
{
wagon.disconnect();
+ redirectServer.stop();
realServer.stop();
tmpResult.delete();
@@ -776,6 +777,7 @@ public void testRedirectGet()
{
wagon.disconnect();
+ redirectServer.stop();
realServer.stop();
tmpResult.delete();
@@ -851,9 +853,9 @@ public void testRedirectPutFromStreamWithFullUrl()
}
finally
{
+ wagon.disconnect();
fileInputStream.close();
tempFile.delete();
-
}
}
@@ -923,9 +925,9 @@ public void testRedirectPutFromStreamRelativeUrl()
}
finally
{
+ wagon.disconnect();
fileInputStream.close();
tempFile.delete();
-
}
}
@@ -1029,6 +1031,7 @@ public void testRedirectPutFileWithFullUrl()
}
finally
{
+ wagon.disconnect();
tempFile.delete();
}
@@ -1092,6 +1095,7 @@ public void testRedirectPutFileRelativeUrl()
}
finally
{
+ wagon.disconnect();
tempFile.delete();
}
diff --git
a/wagon-providers/wagon-file/src/test/java/org/apache/maven/wagon/providers/file/FileWagonTest.java
b/wagon-providers/wagon-file/src/test/java/org/apache/maven/wagon/providers/file/FileWagonTest.java
index 6692988..41da7d4 100644
---
a/wagon-providers/wagon-file/src/test/java/org/apache/maven/wagon/providers/file/FileWagonTest.java
+++
b/wagon-providers/wagon-file/src/test/java/org/apache/maven/wagon/providers/file/FileWagonTest.java
@@ -59,7 +59,7 @@ protected int getTestRepositoryPort() {
/**
* This test is introduced to allow for null file wagons.
* Which is used heavily in the maven component ITs.
- *
+ *
* @throws ConnectionException
* @throws AuthenticationException
*/
@@ -70,28 +70,29 @@ public void testNullFileWagon() throws ConnectionException,
AuthenticationExcept
resource.setContentLength( 100000 );
Repository repository = new Repository();
wagon.connect( repository );
+ wagon.disconnect();
}
protected long getExpectedLastModifiedOnGet( Repository repository,
Resource resource )
{
return new File( repository.getBasedir(), resource.getName()
).lastModified();
}
-
+
public void testResourceExists()
throws Exception
{
String url = "file://" + getBasedir();
-
+
Wagon wagon = new FileWagon();
Repository repository = new Repository( "someID", url );
wagon.connect( repository );
-
+
assertTrue( wagon.resourceExists( "target" ) );
assertTrue( wagon.resourceExists( "target/" ) );
assertTrue( wagon.resourceExists( "pom.xml" ) );
-
+
assertFalse( wagon.resourceExists( "pom.xml/" ) );
-
+
wagon.disconnect();
}
}
diff --git
a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagonTest.java
b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagonTest.java
index c1814f4..15b1f6b 100644
---
a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagonTest.java
+++
b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagonTest.java
@@ -47,5 +47,7 @@ public void test()
inputData.setResource( resource );
wagon.fillInputData( inputData );
+
+ wagon.disconnect();
}
}
diff --git
a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTimeoutTest.java
b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTimeoutTest.java
index 9d2c0eb..5983b4f 100644
---
a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTimeoutTest.java
+++
b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTimeoutTest.java
@@ -198,6 +198,8 @@ public void testConnectionTimeout()
wagon.getFileList( "/foobar" );
long end = System.currentTimeMillis();
+ wagon.disconnect();
+
// validate we have a default time out 60000
assertTrue( (end - start) >= 500 && (end - start) < 1000 );
diff --git
a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HugeFileDownloadTest.java
b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HugeFileDownloadTest.java
index ce91461..01e13f8 100644
---
a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HugeFileDownloadTest.java
+++
b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HugeFileDownloadTest.java
@@ -85,7 +85,7 @@ public void testDownloadHugeFileWithContentLength()
}
finally
{
- server.start();
+ server.stop();
dest.delete();
hugeFile.delete();
}
@@ -144,7 +144,7 @@ protected void doGet( HttpServletRequest req,
HttpServletResponse resp )
}
finally
{
- server.start();
+ server.stop();
dest.delete();
hugeFile.delete();
}
diff --git
a/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagonWithProxyTest.java
b/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagonWithProxyTest.java
index 48bc173..f21a6f5 100644
---
a/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagonWithProxyTest.java
+++
b/wagon-providers/wagon-ssh/src/test/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagonWithProxyTest.java
@@ -83,10 +83,8 @@ public void handle( String target, Request baseRequest,
HttpServletRequest reque
}
finally
{
- if ( server != null )
- {
- server.stop();
- }
+ wagon.disconnect();
+ server.stop();
}
}
@@ -120,6 +118,7 @@ public void testSocksProxy()
}
finally
{
+ wagon.disconnect();
t.interrupt();
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
