+1
Am 02/05/17 um 21:57 schrieb Michael Osipov: > Am 2017-02-04 um 23:31 schrieb Christian Schulte: >> I added a comment below >> >>> http://git-wip-us.apache.org/repos/asf/maven/blob/87c6346a/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java >>> ---------------------------------------------------------------------- >>> diff --git >>> a/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java >>> >>> b/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java >>> index c98dd05..4fb0e32 100644 >>> --- >>> a/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java >>> +++ >>> b/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java >>> @@ -108,14 +108,32 @@ public class MetadataResolutionRequest >>> return this; >>> } >>> >>> + /** >>> + * @deprecated instead use {@link #getRemoteRepositories()} >>> + */ >>> + @Deprecated >>> public List<ArtifactRepository> getRemoteRepostories() >>> { >>> + return getRemoteRepositories(); >>> + } >>> + >>> + public List<ArtifactRepository> getRemoteRepositories() >>> + { >>> return remoteRepositories; >>> } >> >> This should be the other way around. The new method needs to call the >> old method and the old method must not change. So that we can update to >> call the non-deprecated/new methods everywhere without running into that >> old method could have been overridden issue. > > I have amended the commit, please have another look. This should be just > like you proposed. > > Michael > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
