Hi all, At which line is NPE? [1] looks like multithreading. Is NPE cause due to Java Memory Model? One thread is writer, seconds is reader, and object is not thread-safe (immutable, synchronized either volatile). [1] https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commitdiff;h=238f789ad07a18c0dff7f884c9a5d3b47258fc47
On Fri, Feb 17, 2017 at 5:24 PM, Robert Scholte <rfscho...@apache.org> wrote: > Hi Karl Heinz, > > looking at the commit[1] I see that the projectBuildList.contains will > prevent the NPE, but it looks weird to me that the projectBuildList does > not contain a mavenProject which was marked as finished so can be built. > Why is it null? > If there's no clear reason yet, there should be at least an else-statement > logging this. > Looks to me more like a NPE prevention instead of fixing the root cause. > > -1 for me. > > thanks, > Robert > > [1] https://git1-us-west.apache.org/repos/asf?p=maven.git;a=comm > itdiff;h=238f789ad07a18c0dff7f884c9a5d3b47258fc47 > > > > On Fri, 17 Feb 2017 16:56:23 +0100, Karl Heinz Marbaise <khmarba...@gmx.de> > wrote: > > Hi, >> >> I have identified a bug[1] in Maven Core based on an issue related to >> versions-maven-plugin: >> >> I have made already a fix for it and all tests are running[2]. >> >> Any objection to merge that issue into master ? >> >> Kind regards >> Karl Heinz Marbaise >> >> [1]: https://issues.apache.org/jira/browse/MNG-6170 >> [2]: https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x- >> jenkinsfile/job/MNG-6170/ >> >> >> On 08/02/17 21:01, Stephen Connolly wrote: >> >>> I think all the important stuff is merged. I'll take a final review >>> through >>> and then cut alpha-1 >>> >>> We can still add stuff if necessary for an alpha-2 but I'd much prefer to >>> focus that on shaking out bugs. >>> >>> Ideally we do at most 3 alpha's before soft-code-freeze and a beta (at >>> which point it should only be serious bug fixes) >>> >>> Then we give the beta some soak and cut the release >>> >>> I toyed with spinning RCs but I'm thinking alpha and beta are better >>> terms >>> >>> Thoughts? >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Cheers Tibor
