Yes, I will cancel it, and I will add few more fixes too. On Wed, Apr 5, 2017 at 7:01 PM, Michael Osipov <micha...@apache.org> wrote:
> Am 2017-04-05 um 17:20 schrieb Tibor Digana: > >> I found the issue. >> In ForkedBooter we call >> >> encodeAndWriteToOutput( ( (char) BOOTERCODE_BYE ) + ",0,BYE!\n", >> originalOut ); >> >> We expect the Maven process to respond. >> This happens but the listener which is expected to listen to BYE_ACK from >> Maven process is registered after this sending BYE and not before. >> Therefore this is concurrency issue. >> > > +1. Are you going to cancel the vote? > > On Wed, Apr 5, 2017 at 12:31 PM, Petr Široký <siroky.p...@gmail.com> >> wrote: >> >> I've just tried on Windwos 2012R2 + Maven 3.2.3 and RHEL 7.3 + Maven >>> 3.2.5. >>> The 30s wait is somehow intermittent. I can still reproduce on those >>> platforms, but it takes 10 or 15 tries. On Fedora 25 it happens almost >>> always (but I have seen it pass also there). >>> >>> On Wed, Apr 5, 2017 at 11:50 AM Tibor Digana <tibordig...@apache.org> >>> wrote: >>> >>> On my side okay (Maven 3.5.0 Win7). >>>> I will check it out on Fedora and Ubuntu. >>>> >>>> mvn test >>>> [INFO] Scanning for projects... >>>> [INFO] >>>> [INFO] >>>> ------------------------------------------------------------ >>>> ------------ >>>> [INFO] Building surefire-2_20-slowdown-reproducer 1.0-SNAPSHOT >>>> [INFO] >>>> ------------------------------------------------------------ >>>> ------------ >>>> [INFO] >>>> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ >>>> surefire-2_20-slowdown-reproducer --- >>>> [WARNING] Using platform encoding (Cp1250 actually) to copy filtered >>>> resources, i.e. build is platform dependent! >>>> [INFO] skip non existing resourceDirectory >>>> d:\vcs\github\surefire-2_20-slowdown-reproducer\src\main\resources >>>> [INFO] >>>> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ >>>> surefire-2_20-slowdown-reproducer --- >>>> [INFO] Changes detected - recompiling the module! >>>> [WARNING] File encoding has not been set, using platform encoding >>>> Cp1250, >>>> i.e. build is platform dependent! >>>> [INFO] Compiling 1 source file to >>>> d:\vcs\github\surefire-2_20-slowdown-reproducer\target\classes >>>> [INFO] >>>> [INFO] --- maven-resources-plugin:2.6:testResources >>>> >>> (default-testResources) >>> >>>> @ surefire-2_20-slowdown-reproducer --- >>>> [WARNING] Using platform encoding (Cp1250 actually) to copy filtered >>>> resources, i.e. build is platform dependent! >>>> [INFO] skip non existing resourceDirectory >>>> d:\vcs\github\surefire-2_20-slowdown-reproducer\src\test\resources >>>> [INFO] >>>> [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) >>>> @ >>>> surefire-2_20-slowdown-reproducer --- >>>> [INFO] Changes detected - recompiling the module! >>>> [WARNING] File encoding has not been set, using platform encoding >>>> Cp1250, >>>> i.e. build is platform dependent! >>>> [INFO] Compiling 2 source files to >>>> d:\vcs\github\surefire-2_20-slowdown-reproducer\target\test-classes >>>> [INFO] >>>> [INFO] --- maven-surefire-plugin:2.20:test (default-test) @ >>>> surefire-2_20-slowdown-reproducer --- >>>> [INFO] >>>> [INFO] ------------------------------------------------------- >>>> [INFO] T E S T S >>>> [INFO] ------------------------------------------------------- >>>> [INFO] Running org.test.AppTest >>>> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: >>>> >>> 0.01 >>> >>>> s - in org.test.AppTest >>>> [INFO] >>>> [INFO] Results: >>>> [INFO] >>>> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 >>>> [INFO] >>>> [INFO] >>>> ------------------------------------------------------------ >>>> ------------ >>>> [INFO] BUILD SUCCESS >>>> [INFO] >>>> ------------------------------------------------------------ >>>> ------------ >>>> [INFO] Total time: 6.595 s >>>> [INFO] Finished at: 2017-04-05T11:48:06+02:00 >>>> [INFO] Final Memory: 16M/212M >>>> [INFO] >>>> ------------------------------------------------------------ >>>> ------------ >>>> >>>> On Wed, Apr 5, 2017 at 11:26 AM, Tibor Digana-2 [via Maven] < >>>> ml-node+s40175n5904641...@n5.nabble.com> wrote: >>>> >>>> Discussion to Release Vote of Surefire 2.20. >>>>> Project to reproduce an issue >>>>> https://github.com/psiroky/surefire-2_20-slowdown-reproducer >>>>> Forked JVM is waiting 30 seconds to die. >>>>> >>>>> I guess the JVM does not exit due to non-daemon threads. >>>>> Question is why we can see RMI Threads however no test is using RMI. >>>>> >>>>> -- >>>>> Cheers >>>>> Tibor >>>>> >>>>> >>>>> ------------------------------ >>>>> If you reply to this email, your message will be added to the >>>>> >>>> discussion >>> >>>> below: >>>>> http://maven.40175.n5.nabble.com/surefire-2-20-slowdown- >>>>> reproducer-tp5904641.html >>>>> To start a new topic under Maven Developers, email >>>>> ml-node+s40175n142166...@n5.nabble.com >>>>> To unsubscribe from Maven Developers, click here >>>>> < >>>>> >>>> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp? >>>> >>> macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAY >>> XBhY2hlLm9yZ3 >>> wxNDIxNjZ8LTI4OTQ5MjEwMg== >>> >>>> >>>>> . >>>>> NAML >>>>> < >>>>> >>>> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp? >>>> >>> macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml& >>> base=nabble.naml.namespaces.BasicNamespace-nabble.view. >>> web.template.NabbleNamespace-nabble.view.web.template. >>> NodeNamespace&breadcrumbs=notify_subscribers%21nabble% >>> 3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_ >>> instant_email%21nabble%3Aemail.naml >>> >>>> >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://maven.40175.n5.nabble.com/surefire-2-20-slowdown- >>>> >>> reproducer-tp5904641p5904652.html >>> >>>> Sent from the Maven Developers mailing list archive at Nabble.com. >>>> >>> >>> >> >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Cheers Tibor
