Hi Igor, On 07/04/17 17:21, Igor Fedorenko wrote:
I have two of small-ish fixes I'd like to submit, so I was wondering if master is open for 3.5.1 changes already or we want to give it little more time in case we need to release any emergency patches.
If that's really necessary we can simply make a branch for that emergency patch...
Also, what is the general bug fixing protocol now, push to directly to master and be prepared to revert or always go through a pull-request-review process? I don't mind going the code review route, but in this particular case both changes touch 1-2 lines of code not counting regression test code, so I am not sure how much value formal code review process will provide.
I would suggest to create appropriate branches per jira issue (MNG-6210, MNG-6209) for it and then we can see if IT's working well and afterwards merging them to master via fast-forward. This will prevent several commits/reverts on master...so we keep the history clean..
Also, does anyone know how to get my JIRA account fixed so I can assign/close/etc bugs?
You are not allowed to do? Write an INFRA ticket...in the meantime I or others can help here with that...
Thank you in advance. https://issues.apache.org/jira/browse/MNG-6210 https://issues.apache.org/jira/browse/MNG-6209
Kind regards Karl Heinz Marbaise --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
