Just tested with local build from f4f78c9f155 (2.20-SNAPSHOT). Several large projects, no additional issue found.
Petr On Sat, Apr 8, 2017 at 12:28 AM Tibor Digana <tibor.dig...@googlemail.com> wrote: > The CI build will finish after 3 hours. > Then the SNAPSHOT version will be in Maven Central. > > On Fri, Apr 7, 2017 at 11:40 PM, Dan Tran <dant...@gmail.com> wrote: > > > is 2.20-SNAPSHOT up to date? that is only quick way I can test > > > > Thanks > > > > -D > > > > On Fri, Apr 7, 2017 at 2:03 PM, Tibor Digana < > tibor.dig...@googlemail.com> > > wrote: > > > > > @Petr > > > Both issues are fixed now. Would you please verify this version from > > > master? I tested on my side. > > > > > > On Fri, Apr 7, 2017 at 3:42 PM, Petr Široký <siroky.p...@gmail.com> > > wrote: > > > > > > > I'try to take a look. However, I have no prior experience with jUnit > or > > > > surefire sources, so it might take a while until I have something. > > > > > > > > Thanks, > > > > Petr > > > > > > > > On Fri, Apr 7, 2017 at 2:22 PM Tibor Digana < > > tibor.dig...@googlemail.com > > > > > > > > wrote: > > > > > > > > > Good point. The PING chcking should be disabled when JMX observes > > debug > > > > > mode. > > > > > See implementation in JUnit sources. The same is there. > > > > > Can you open pull request with a fix? > > > > > > > > > > On Fri, Apr 7, 2017 at 11:06 AM, Petr Široký < > siroky.p...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hello, > > > > > > > > > > > > thanks for the fast turnaround. > > > > > > > > > > > > I am afraid I've hit another issue (or maybe misconfiguration?). > I > > > was > > > > > > trying to use -Dmaven.surefire.debug in the following project: > > > > > > https://github.com/psiroky/surefire-2.20-debug-reproducer > > > > > > > > > > > > $ mvn clean install -s settings.xml -Dmaven.surefire.debug > > > > > > > > > > > > The surefire stops the execution and waits for the remote > > connection > > > on > > > > > the > > > > > > default port 5005. However, I see this warning: > > > > > > [WARNING] Corrupted stdin stream in forked JVM 2. See the dump > file > > > > > > /home/psiroky/tmp/surefire-2.20-debug/target/surefire- > > > > > > reports/2017-04-07T11-00-40_341-jvmRun2.dumpstream > > > > > > > > > > > > Also, once I disconnect the remote debugger, the build fails with > > > > > > "ExecutionException The forked VM terminated without properly > > saying > > > > > > goodbye. VM crash or System.exit called?" > > > > > > See the full build.log in the above git repo. I've also included > > the > > > > > > '.dumpstream' file. > > > > > > > > > > > > Petr > > > > > > > > > > > > > > > > > > On Thu, Apr 6, 2017 at 7:56 AM Tibor Digana < > > tibordig...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > We solved 68 issues: > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > > > > projectId=12317927&version=12334636 > > > > > > > > > > > > > > There are still a couple of issues left in JIRA: > > > > > > > > > > > > > > https://issues.apache.org/jira/i#issues/?jql=project+% > > > > > > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC > > > > > > > > > > > > > > Staging repo: > > > > > > > https://repository.apache.org/content/repositories/maven-1329/ > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/maven- > > > > > > > > > > > 1329/org/apache/maven/surefire/surefire/2.20/ > > > > surefire-2.20-source-release. > > > > > > zip > > > > > > > > > > > > > > Source release checksum(s): > > > > > > > surefire-2.20-source-release.zip sha1: > > > > > > > d76d172588f6ab1ada16db9155b464ffeefffc9b > > > > > > > > > > > > > > Git tag: > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=maven-surefire. > > > git;a=commit;h= > > > > > > b5cbc6b2822e9eb60c703d46f1d2ed82126909ed > > > > > > > > > > > > > > Staging site: > > > > > > > http://maven.apache.org/surefire-archives/surefire-LATEST/ > > > > > > > > > > > > > > Guide to testing staged releases: > > > > > > > http://maven.apache.org/guides/development/guide- > > > > testing-releases.html > > > > > > > > > > > > > > Vote open for 72 hours. > > > > > > > > > > > > > > [ ] +1 > > > > > > > [ ] +0 > > > > > > > [ ] -1 > > > > > > > > > > > > > > Cheers, > > > > > > > Tibor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Cheers > > > > > Tibor > > > > > > > > > > > > > > > > > > > > > -- > > > Cheers > > > Tibor > > > > > > > > > -- > Cheers > Tibor >
