GitHub user mgreau opened a pull request:
https://github.com/apache/maven-surefire/pull/146
SUREFIRE-1330: Fix module name in surefire-providers reactor
This PR fixes the JUnit5 module name `surefire-junit-platform` in the
`surefire-providers` POM reactor.
<details>
<summary>Build logs results with and without the fix</summary>
Indeed, without this PR I can't build the project on this branch:
```
ââmgreau@mbpro ~/GIT/mgreau/maven-surefire â¹3.0-rc1âº
â°â$ mvn clean install
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Child module
/Users/mgreau/Dev/Sources/eXo/all_git_repos/mgreau/maven-surefire/surefire-providers/surefire-junit5
of
/Users/mgreau/Dev/Sources/eXo/all_git_repos/mgreau/maven-surefire/surefire-providers/pom.xml
does not exist @
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project
org.apache.maven.surefire:surefire-providers:2.19.2-SNAPSHOT
(/Users/mgreau/Dev/Sources/eXo/all_git_repos/mgreau/maven-surefire/surefire-providers/pom.xml)
has 1 error
[ERROR] Child module
/Users/mgreau/Dev/Sources/eXo/all_git_repos/mgreau/maven-surefire/surefire-providers/surefire-junit5
of
/Users/mgreau/Dev/Sources/eXo/all_git_repos/mgreau/maven-surefire/surefire-providers/pom.xml
does not exist
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
```
With this PR, I have a Build Failure because of the module `Maven Surefire
Integration Tests` but the reactor is OK:
```
Tests run: 701, Failures: 36, Errors: 498, Skipped: 133
[INFO]
[INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @
surefire-integration-tests ---
[INFO]
[INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @
surefire-integration-tests ---
[INFO] Failsafe report directory:
/Users/mgreau/Dev/Sources/eXo/all_git_repos/3party/maven-surefire/surefire-integration-tests/target/failsafe-reports
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven Surefire .............................. SUCCESS [
3.863 s]
[INFO] ShadeFire JUnit3 Provider .......................... SUCCESS [
3.156 s]
[INFO] SureFire API ....................................... SUCCESS [
4.231 s]
[INFO] SureFire Booter .................................... SUCCESS [
1.602 s]
[INFO] Maven Surefire Test-Grouping Support ............... SUCCESS [
1.314 s]
[INFO] SureFire Providers ................................. SUCCESS [
0.516 s]
[INFO] Shared JUnit3 Provider Code ........................ SUCCESS [
0.799 s]
[INFO] Shared Java 5 Provider Base ........................ SUCCESS [
1.042 s]
[INFO] Shared JUnit4 Provider Code ........................ SUCCESS [
1.136 s]
[INFO] Shared JUnit48 Provider Code ....................... SUCCESS [
1.686 s]
[INFO] SureFire JUnit Runner .............................. SUCCESS [
1.018 s]
[INFO] SureFire JUnit4 Runner ............................. SUCCESS [
1.400 s]
[INFO] Maven Surefire Common .............................. SUCCESS [
4.381 s]
[INFO] SureFire JUnitCore Runner .......................... SUCCESS [
49.355 s]
[INFO] SureFire JUnit Platform Runner ..................... SUCCESS [
1.624 s]
[INFO] SureFire TestNG Utils .............................. SUCCESS [
0.909 s]
[INFO] SureFire TestNG Runner ............................. SUCCESS [
1.702 s]
[INFO] Surefire Report Parser ............................. SUCCESS [
1.346 s]
[INFO] Maven Surefire Plugin .............................. SUCCESS [
3.826 s]
[INFO] Maven Failsafe Plugin .............................. SUCCESS [
2.514 s]
[INFO] Maven Surefire Report Plugin ....................... SUCCESS [
7.545 s]
[INFO] Maven Surefire Integration Test Setup .............. SUCCESS [
34.920 s]
[INFO] Maven Surefire Integration Tests ................... FAILURE [23:41
min]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 25:51 min
[INFO] Finished at: 2017-04-11T15:34:37+02:00
[INFO] Final Memory: 85M/1284M
[INFO]
------------------------------------------------------------------------
```
</details>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgreau/maven-surefire SUREFIRE-1330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit 70c8843e935882b0a78916894cb9f042964f2717
Author: Maxime Gréau <mgr...@exoplatform.com>
Date: 2017-04-11T13:32:10Z
SUREFIRE-1330: Fix module name in surefire-providers reactor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
