Will do. Thank you.
--
Regards,
Igor
On April 13, 2017 3:55:43 PM Stephen Connolly
<stephen.alan.conno...@gmail.com> wrote:
Just be sure to delete the branch after merging so that the job will get
cleaned up (in 3 days time - retention strategy)
On Thu 13 Apr 2017 at 23:53, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:
None here!
On Thu 13 Apr 2017 at 23:30, Igor Fedorenko <i...@ifedorenko.com> wrote:
Thank you for the explanation, didn't find this job.
Now that both branch builds are happy, any objections I merge then to
master?
--
Regards,
Igor
On April 13, 2017 1:20:24 PM Karl Heinz Marbaise <khmarba...@gmx.de>
wrote:
> Hi Igor,
>
>
> On 13/04/17 22:09, Igor Fedorenko wrote:
>> I pushed my changes to feature branches. How do I trigger CI builds
now?
>
> They are already running your builds...
>
> Take a look here:
>
>
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/
>
> Kind regards
> Karl Heinz Marbaise
>
>
>>
>> --
>> Regards,
>> Igor
>>
>>
>>
>> On April 7, 2017 9:24:06 AM Igor Fedorenko <i...@ifedorenko.com>
wrote:
>>
>>> I completely agree we need to prove each code change does not break
>>> existing integration tests (and I did run the tests locally with my
>>> changes, fwiw)
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> On Fri, Apr 7, 2017, at 11:58 AM, Stephen Connolly wrote:
>>>> I want every issue that changes code (not docs or javadocs) to have
an
>>>> integration test run before merging.
>>>>
>>>> We were trying to get consensus on a process but the debate died
without
>>>> a
>>>> conclusion
>>>>
>>>> On Fri 7 Apr 2017 at 16:21, Igor Fedorenko <i...@ifedorenko.com>
wrote:
>>>>
>>>> > I have two of small-ish fixes I'd like to submit, so I was
>>>> wondering if
>>>> > master is open for 3.5.1 changes already or we want to give it
little
>>>> > more time in case we need to release any emergency patches.
>>>> >
>>>> > Also, what is the general bug fixing protocol now, push to
directly to
>>>> > master and be prepared to revert or always go through a
>>>> > pull-request-review process? I don't mind going the code review
route,
>>>> > but in this particular case both changes touch 1-2 lines of code
not
>>>> > counting regression test code, so I am not sure how much value
formal
>>>> > code review process will provide.
>>>> >
>>>> > Also, does anyone know how to get my JIRA account fixed so I can
>>>> > assign/close/etc bugs?
>>>> >
>>>> > Thank you in advance.
>>>> >
>>>> >
>>>> > https://issues.apache.org/jira/browse/MNG-6210
>>>> > https://issues.apache.org/jira/browse/MNG-6209
>>>> >
>>>> > --
>>>> > Regards,
>>>> > Igor
>>>> >
>>>> >
---------------------------------------------------------------------
>>>> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>>> > For additional commands, e-mail: dev-h...@maven.apache.org
>>>> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--
Sent from my phone
--
Sent from my phone
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
