Hi Karl Heinz,
comparing the key is often good enough, but I wonder if we should include
the packaging type as well.
On the other hand, if there's another module with the same GA, then you'll
have an issue as well.
Would be good to add a comment here that says ignoring type and
classifiers is intended and seems valid here for the reason mentioned
above.
thanks,
Robert
On Sun, 30 Jul 2017 13:25:12 +0200, Karl Heinz Marbaise
<[email protected]> wrote:
Hi Robert,
On 30/07/17 12:56, Robert Scholte wrote:
I'm missing the code change, I see only IT changes.
Sure...missed the link:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=65bb3030193db6b5c0d55c0f00f94f2dc77b801d
On the branch:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=shortlog;h=refs/heads/MNG-6123-detect-self-references
Kind regards
Karl Heinz Marbaise
On Fri, 28 Jul 2017 22:03:15 +0200, Karl Heinz Marbaise
<[email protected]> wrote:
Hi,
I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which
needs a small change to one of the integration tests[2]
The IT's are fine see[3]
Are any objections?
If there are no objections I would like to merge to master on
tuesday...
Kind regards
Karl Heinz Marbaise
[1]: https://issues.apache.org/jira/browse/MNG-6123
[2]:
https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=3a1f095ec845c94b8e21ea28e4ffe69a01c29f4b
[3]:
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6123-detect-self-references/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Mit freundlichem Gruß
Karl-Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
