I agree, it would be nice if this one was shipped with one of the next releases, as long as it's stable. I was kind of surprised that the contextloader could be null, but after reading the docs this change makes sense. I was too fast with the revert, meaning you could reintroduce the unit-test, which was the original symptom.

Robert

On Wed, 30 Aug 2017 11:31:30 +0200, Stephen Connolly <[email protected]> wrote:

https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/mng-6275/
will report the status... I am more in favour of including MNG-6275 rather
than reverting, but let's get Igor's opinion after we (hopefully) get a
clean test run.

Absence a clean test run on
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/mng-6275/
then I say revert and descope for 3.5.1 as it is no worse than before on
Java 8 and I'm happy to take time and roll a 3.5.2 for this rather than
hold up a release train for something that is not a regression from 3.5.0

On 30 August 2017 at 02:26, Stephen Connolly <
[email protected]> wrote:

https://github.com/apache/maven/commit/39004f6aee634a0ac6daa1f99add29
9ff439f5ec should fix

On 30 August 2017 at 02:09, Robert Scholte <[email protected]> wrote:

Now that the ITs are all in place again it is good to see that these
failures reflect the concerns of Igor.
Originally this issue said it was Java 9 related, but this is a Java 8
issue as well, so there's no real need to include it for 3.5.1
I'll revert this commit and reopen the issue.
Future analysis must answer the question where and how the classloading
must be improved.

Robert


On Wed, 30 Aug 2017 01:57:02 +0200, Stephen Connolly <
[email protected]> wrote:

Ok, looking a the results of the bisect-0 through bisect-3 builds, 0 and 1
both fail just for the MNG-6127 integration tests, bisect-2 adds the fix for MNG-6127, so the build passes... bisect-3 also passes, so the smoking
gun is...

https://github.com/apache/maven/commit/f047ea143766fd22ae420
40e6805bef287f3cc3e

On 29 August 2017 at 22:17, Stephen Connolly <
[email protected]> wrote:

bisect-0 is the last known good commit with the Jenkinsfile fix to
confirm
that the failures are not another infra related change

On 29 August 2017 at 22:13, Stephen Connolly
<stephen.alan.connolly@gmail.
com> wrote:

I have pushed bisect-1, bisect-2 and bisect-3 to see if we can identify
the problematic commit since the last known good build of master (#123
for
commit 4f2a2dba89251d9045fe9944783509a397491da3)

On 29 August 2017 at 22:09, Stephen Connolly <
[email protected]> wrote:

Failure is in testBootstrap, probably something obvious, here's the
problematic build log... you can inspect for yourself at
https://builds.apache.org/blue/organizations/jenkins/mave
n-3.x-jenkinsfile/detail/master/128/tests but there is no point in
looking at any tests other than testBootstrap as if that fails
everything
else will fail too

[WARNING] Error injecting: org.apache.maven.plugins.depen
dency.resolvers.ResolvePluginsMojo
com.google.inject.ProvisionException: Unable to provision, see the
following errors:
1) No implementation for org.apache.maven.artifact.hand
ler.manager.ArtifactHandlerManager was bound.
  while locating org.apache.maven.plugins.depen
dency.resolvers.ResolvePluginsMojo
1 error
 at com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.j
ava:1025)
 at com.google.inject.internal.InjectorImpl.getInstance(Injector
Impl.java:1051)
 at org.eclipse.sisu.space.AbstractDeferredClass.get(AbstractDef
erredClass.java:48)
 at com.google.inject.internal.ProviderInternalFactory.provision
(ProviderInternalFactory.java:81)
 at com.google.inject.internal.InternalFactoryToInitializableAda
pter.provision(InternalFactoryToInitializableAdapter.java:53)
 at com.google.inject.internal.ProviderInternalFactory$1.call(Pr
oviderInternalFactory.java:65)
 at com.google.inject.internal.ProvisionListenerStackCallback$Pr
ovision.provision(ProvisionListenerStackCallback.java:115)
 at com.google.inject.internal.ProvisionListenerStackCallback$Pr
ovision.provision(ProvisionListenerStackCallback.java:133)
 at com.google.inject.internal.ProvisionListenerStackCallback.pr
ovision(ProvisionListenerStackCallback.java:68)
 at com.google.inject.internal.ProviderInternalFactory.circularG
et(ProviderInternalFactory.java:63)
 at com.google.inject.internal.InternalFactoryToInitializableAda
pter.get(InternalFactoryToInitializableAdapter.java:45)
 at com.google.inject.internal.InjectorImpl$2$1.call(InjectorImp
l.java:1016)
 at com.google.inject.internal.InjectorImpl.callInContext(Inject
orImpl.java:1092)
 at com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.j
ava:1012)
 at org.eclipse.sisu.inject.Guice4$1.get(Guice4.java:162)
 at org.eclipse.sisu.inject.LazyBeanEntry.getValue(LazyBeanEntry
.java:81)
 at org.eclipse.sisu.plexus.LazyPlexusBean.getValue(LazyPlexusBe
an.java:51)
 at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPle
xusContainer.java:263)
 at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPle
xusContainer.java:255)
 at org.apache.maven.plugin.internal.DefaultMavenPluginManager.g
etConfiguredMojo(DefaultMavenPluginManager.java:519)
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMoj
o(DefaultBuildPluginManager.java:124)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj
oExecutor.java:208)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj
oExecutor.java:154)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj
oExecutor.java:146)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b
uildProject(LifecycleModuleBuilder.java:117)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b
uildProject(LifecycleModuleBuilder.java:81)
 at org.apache.maven.lifecycle.internal.builder.singlethreaded.S
ingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
 at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
 at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
 at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
 at org.apache.maven.cli.MavenCli.execute(MavenCli.java:955)
 at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290)
 at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:245)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
ssorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
thodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:498)
 at org.apache.maven.it.Embedded3xLauncher.run(Embedded3xLaunche
r.java:247)
 at org.apache.maven.it.Verifier.executeGoals(Verifier.java:1354)
 at org.apache.maven.it.Verifier.executeGoal(Verifier.java:1254)
 at org.apache.maven.it.Verifier.executeGoal(Verifier.java:1248)
 at org.apache.maven.it.MavenITBootstrapTest.testBootstrap(Maven
ITBootstrapTest.java:54)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
ssorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
thodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:498)
 at junit.framework.TestCase.runTest(TestCase.java:168)
 at org.apache.maven.it.AbstractMavenIntegrationTestCase.runTest
(AbstractMavenIntegrationTestCase.java:222)
 at junit.framework.TestCase.runBare(TestCase.java:134)
 at junit.framework.TestResult$1.protect(TestResult.java:110)
 at junit.framework.TestResult.runProtected(TestResult.java:128)
 at junit.framework.TestResult.run(TestResult.java:113)
 at junit.framework.TestCase.run(TestCase.java:124)
 at junit.framework.TestSuite.runTest(TestSuite.java:243)
 at junit.framework.TestSuite.run(TestSuite.java:238)
 at junit.framework.TestSuite.runTest(TestSuite.java:243)
 at junit.framework.TestSuite.run(TestSuite.java:238)
 at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38Cla
ssRunner.java:83)
 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUni
t4Provider.java:283)
 at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithR
erun(JUnit4Provider.java:173)
 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestS
et(JUnit4Provider.java:153)
 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit
4Provider.java:128)
 at org.apache.maven.surefire.booter.ForkedBooter.invokeProvider
InSameClassLoader(ForkedBooter.java:203)
 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInPro
cess(ForkedBooter.java:155)
 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBoo
ter.java:103)
[INFO] ------------------------------------------------------------
------------
[INFO] Reactor Summary:
[INFO]
[INFO] Maven Integration Test :: Boostrap ................. FAILURE [
 2.136 s]
[INFO] Maven Integration Test :: Boostrap :: Group-1 ...... SKIPPED
[INFO] Maven Integration Test :: Boostrap :: Group-2 ...... SKIPPED
[INFO] Maven Integration Test :: Boostrap :: Group-3 ...... SKIPPED
[INFO] Maven Integration Test :: Boostrap :: Group-4 ...... SKIPPED
[INFO] Maven Integration Test :: Boostrap :: Group-5 ...... SKIPPED
[INFO] Maven Integration Test :: Boostrap :: Group-6 ...... SKIPPED
[INFO] Maven Integration Test :: Boostrap :: Group-7 ...... SKIPPED
[INFO] ------------------------------------------------------------
------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------
------------
[INFO] Total time: 2.379 s
[INFO] Finished at: 2017-08-29T20:53:51Z
[INFO] Final Memory: 18M/260M
[INFO] ------------------------------------------------------------
------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven
-dependency-plugin:3.0.0:resolve-plugins (get-all-plugins-deps) on
project maven-it-boostrap: Execution get-all-plugins-deps of goal
org.apache.maven.plugins:maven-dependency-plugin:3.0.0:resol
ve-plugins
failed: Unable to load the mojo 'resolve-plugins' (or one of its
required
components) from the plugin 'org.apache.maven.plugins:mave
n-dependency-plugin:3.0.0':
com.google.inject.ProvisionException: Unable to provision, see the
following errors:
[ERROR]
[ERROR] 1) No implementation for org.apache.maven.artifact.hand
ler.manager.ArtifactHandlerManager was bound.
[ERROR]   while locating org.apache.maven.plugins.depen
dency.resolvers.ResolvePluginsMojo
[ERROR]   at ClassRealm[plugin>org.apache.m
aven.plugins:maven-dependency-plugin:3.0.0, parent:
java.net.URLClassLoader@77f03bb1] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.Plexus
BindingModule)
[ERROR] while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins
:maven-dependency-plugin:3.0.0:resolve-plugins)
[ERROR]
[ERROR] 1 error
[ERROR]       role: org.apache.maven.plugin.Mojo
[ERROR]   roleHint: org.apache.maven.plugins:maven
-dependency-plugin:3.0.0:resolve-plugins
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal org.apache.maven.plugins:maven
-dependency-plugin:3.0.0:resolve-plugins (get-all-plugins-deps) on
project maven-it-boostrap: Execution get-all-plugins-deps of goal
org.apache.maven.plugins:maven-dependency-plugin:3.0.0:resol
ve-plugins
failed: Unable to load the mojo 'resolve-plugins' (or one of its
required
components) from the plugin 'org.apache.maven.plugins:mave
n-dependency-plugin:3.0.0'
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj
oExecutor.java:213)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj
oExecutor.java:154)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj
oExecutor.java:146)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b
uildProject(LifecycleModuleBuilder.java:117)
 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b
uildProject(LifecycleModuleBuilder.java:81)
 at org.apache.maven.lifecycle.internal.builder.singlethreaded.S
ingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute

(LifecycleStarter.java:128)
 at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
 at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
 at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
 at org.apache.maven.cli.MavenCli.execute(MavenCli.java:955)
 at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290)
 at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:245)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
ssorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
thodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:498)
 at org.apache.maven.it.Embedded3xLauncher.run(Embedded3xLaunche
r.java:247)
 at org.apache.maven.it.Verifier.executeGoals(Verifier.java:1354)
 at org.apache.maven.it.Verifier.executeGoal(Verifier.java:1254)
 at org.apache.maven.it.Verifier.executeGoal(Verifier.java:1248)
 at org.apache.maven.it.MavenITBootstrapTest.testBootstrap(Maven
ITBootstrapTest.java:54)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
ssorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
thodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:498)
 at junit.framework.TestCase.runTest(TestCase.java:168)
 at org.apache.maven.it.AbstractMavenIntegrationTestCase.runTest
(AbstractMavenIntegrationTestCase.java:222)
 at junit.framework.TestCase.runBare(TestCase.java:134)
 at junit.framework.TestResult$1.protect(TestResult.java:110)
 at junit.framework.TestResult.runProtected(TestResult.java:128)
 at junit.framework.TestResult.run(TestResult.java:113)
 at junit.framework.TestCase.run(TestCase.java:124)
 at junit.framework.TestSuite.runTest(TestSuite.java:243)
 at junit.framework.TestSuite.run(TestSuite.java:238)
 at junit.framework.TestSuite.runTest(TestSuite.java:243)
 at junit.framework.TestSuite.run(TestSuite.java:238)
 at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38Cla
ssRunner.java:83)
 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUni
t4Provider.java:283)
 at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithR
erun(JUnit4Provider.java:173)
 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestS
et(JUnit4Provider.java:153)
 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit
4Provider.java:128)
 at org.apache.maven.surefire.booter.ForkedBooter.invokeProvider
InSameClassLoader(ForkedBooter.java:203)
 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInPro
cess(ForkedBooter.java:155)
 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBoo
ter.java:103)
Caused by: org.apache.maven.plugin.PluginExecutionException:
Execution
get-all-plugins-deps of goal org.apache.maven.plugins:maven
-dependency-plugin:3.0.0:resolve-plugins failed: Unable to load the
mojo 'resolve-plugins' (or one of its required components) from the
plugin
'org.apache.maven.plugins:maven-dependency-plugin:3.0.0'
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMoj
o(DefaultBuildPluginManager.java:156)
 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj
oExecutor.java:208)
 ... 44 more
Caused by: org.apache.maven.plugin.PluginContainerException: Unable
to
load the mojo 'resolve-plugins' (or one of its required components)
from
the plugin 'org.apache.maven.plugins:maven-dependency-plugin:3.0.0'
 at org.apache.maven.plugin.internal.DefaultMavenPluginManager.g
etConfiguredMojo(DefaultMavenPluginManager.java:553)
 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMoj
o(DefaultBuildPluginManager.java:124)
 ... 45 more
Caused by: org.codehaus.plexus.component.
repository.exception.ComponentLookupException:
com.google.inject.ProvisionException: Unable to provision, see the
following errors:
1) No implementation for org.apache.maven.artifact.hand
ler.manager.ArtifactHandlerManager was bound.
  while locating org.apache.maven.plugins.depen
dency.resolvers.ResolvePluginsMojo
  at ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-
plugin:3.0.0,
parent: java.net.URLClassLoader@77f03bb1] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.Plexus
BindingModule)
  while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins
:maven-dependency-plugin:3.0.0:resolve-plugins)
1 error
      role: org.apache.maven.plugin.Mojo
  roleHint: org.apache.maven.plugins:maven
-dependency-plugin:3.0.0:resol
ve-plugins
 at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPle
xusContainer.java:267)
 at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPle
xusContainer.java:255)
 at org.apache.maven.plugin.internal.DefaultMavenPluginManager.g
etConfiguredMojo(DefaultMavenPluginManager.java:519)
 ... 46 more
Caused by: com.google.inject.ProvisionException: Unable to provision,
see the following errors:
1) No implementation for org.apache.maven.artifact.hand
ler.manager.ArtifactHandlerManager was bound.
  while locating org.apache.maven.plugins.depen
dency.resolvers.ResolvePluginsMojo
  at ClassRealm[plugin>org.apache.maven.plugins:maven-dependency-
plugin:3.0.0,
parent: java.net.URLClassLoader@77f03bb1] (via modules:
org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.Plexus
BindingModule)
  while locating org.apache.maven.plugin.Mojo annotated with
@com.google.inject.name.Named(value=org.apache.maven.plugins
:maven-dependency-plugin:3.0.0:resolve-plugins)
1 error
 at com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.j
ava:1025)
 at org.eclipse.sisu.inject.Guice4$1.get(Guice4.java:162)
 at org.eclipse.sisu.inject.LazyBeanEntry.getValue(LazyBeanEntry
.java:81)
 at org.eclipse.sisu.plexus.LazyPlexusBean.getValue(LazyPlexusBe
an.java:51)
 at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPle
xusContainer.java:263)
 ... 48 more
[ERROR]
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/conflu
ence/display/MAVEN/PluginContainerException




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to