On Sat, 02 Sep 2017 14:06:20 +0200, Karl Heinz Marbaise
<khmarba...@gmx.de> wrote:
Hi Robert,
On 02/09/17 13:30, Robert Scholte wrote:
Hi Karl Heinz,
this is a problem with the error-prone-compiler[1], a specific
implementation of the compiler-api and also where this must be fixed.
You might wonder if it should be tested here, but now we are at least
aware that current error-prone-compiler is not Java9 compatible. It
should not be a blocker for the maven-compiler-plugin itself.
Ok the question is what is exactly the purpose for this
error-prone-compiler part in Maven-Compiler-Plugin (plexus compiler) and
what kind of purpose does it fulfill?
My guess: the maven-compiler-plugin is built/released more often, so with
this construction it is much easier to detect if there are issues with
specific compiler implementations.
So yes, the this plugin is kind of being abused for compatibility checks.
If plexus-compiler has a complete CI setup, we could remove it here (or
just try to fix it when possible).
Robert
Apart from that: +1 from me for releasing maven-compiler-plugin...it
fixes other issues...
Kind regards
Karl Heinz Marbaise
thank,
Robert
[1]
https://github.com/codehaus-plexus/plexus-compiler/tree/master/plexus-compilers/plexus-compiler-javac-errorprone
On Sat, 02 Sep 2017 13:23:50 +0200, Karl Heinz Marbaise
<khmarba...@gmx.de> wrote:
Hi,
I have tested the following combinations:
jdk1.7.0_79.jdk
apache-maven-3.0.5
apache-maven-3.1.1
apache-maven-3.2.5
apache-maven-3.3.1
apache-maven-3.3.9
apache-maven-3.5.0
jdk1.8.0_131.jdk
apache-maven-3.0.5
apache-maven-3.1.1
apache-maven-3.2.5
apache-maven-3.3.1
apache-maven-3.3.9
apache-maven-3.5.0
jdk1.8.0_144.jdk
apache-maven-3.0.5
apache-maven-3.1.1
apache-maven-3.2.5
apache-maven-3.3.1
apache-maven-3.3.9
apache-maven-3.5.0
jdk1.9.0_ea+181.jdk
apache-maven-3.0.5 FAILED!!
apache-maven-3.1.1 FAILED!!
apache-maven-3.2.5 FAILED!!
apache-maven-3.3.1 FAILED!!
apache-maven-3.3.9 FAILED!!
apache-maven-3.5.0 FAILED!!
But the JDK1.9.0_ea+181 have show the following result (for all Maven
versions):
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
(default-compile) on project error-prone-compiler: Fatal error
compiling: CompilerException: InvocationTargetException:
java.nio.file.NotDirectoryException:
/Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
-> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed
to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
(default-compile) on project error-prone-compiler: Fatal error
compiling
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at
org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
java.base/java.lang.reflect.Method.invoke(Method.java:564)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.MojoExecutionException:
Fatal error compiling
at
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1086)
at
org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:168)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: org.codehaus.plexus.compiler.CompilerException
at
org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:95)
at
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1075)
... 22 more
Caused by: java.lang.reflect.InvocationTargetException
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
java.base/java.lang.reflect.Method.invoke(Method.java:564)
at
org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:91)
... 23 more
Caused by: java.io.UncheckedIOException:
java.nio.file.NotDirectoryException:
/Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.lazy(Locations.java:725)
at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.isDefault(Locations.java:559)
at
com.sun.tools.javac.file.Locations.isDefaultBootClassPath(Locations.java:129)
at
com.sun.tools.javac.file.BaseFileManager.isDefaultBootClassPath(BaseFileManager.java:149)
at
com.sun.tools.javac.main.Arguments.validate(Arguments.java:411)
at com.sun.tools.javac.main.Main.compile(Main.java:218)
at
com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:187)
at
com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:98)
at
com.google.errorprone.ErrorProneCompiler.run(ErrorProneCompiler.java:128)
at
org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.compile(JavacCompilerWithErrorProne.java:222)
... 28 more
Caused by: java.nio.file.NotDirectoryException:
/Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
at
java.base/sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:407)
at
java.base/java.nio.file.Files.newDirectoryStream(Files.java:465)
at java.base/java.nio.file.Files.list(Files.java:3524)
at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.systemClasses(Locations.java:678)
at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.computePath(Locations.java:634)
at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.lazy(Locations.java:722)
... 37 more
[ERROR]
[ERROR]
[ERROR] For more information about the errors and possible
solutions, please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Running post-build script:
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+181.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.7.0/target/it/error-prone-compiler/verify.groovy
Based on what I can see here on MacOS: The modules in JDK 9 is a file
and not directory...The question is this an MacOS only phenomenon ? Or
is this a general situation?
Kind regards
Karl Heinz Marbaise
On 01/09/17 15:50, Robert Scholte wrote:
Hi,
We solved 6 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317225&version=12341266&styleName=Text
There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317225%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
Staging repo:
https://repository.apache.org/content/repositories/maven-1359/
https://repository.apache.org/service/local/repositories/maven-1359/content/org/apache/maven/plugins/maven-compiler-plugin/3.7.0/maven-compiler-plugin-3.7.0-source-release.zip
Source release checksum(s):
maven-compiler-plugin-3.7.0-source-release.zip sha1:
1148d8a1f89e6900afb0ca1dbf74f64932402cfd
Staging site:
https://maven.apache.org/plugins-archives/maven-compiler-plugin-LATEST/
Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for at least 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
