Nice fix

On Mon, 11 Sep 2017 11:31:34 +0200, Stephen Connolly <stephen.alan.conno...@gmail.com> wrote:

http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the
test going forward, with that change on Azul's Zulu JDK 7 I get:

Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.7.0_154, vendor: Azul Systems, Inc.
Java home: /usr/lib/jvm/zulu-7-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS


On 11 September 2017 at 02:00, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

So Azul's Zulu 7 does not have

com.sun.script.javascript.RhinoScriptEngineFactory or any
ScriptEngineFactory in the base classloader...

Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory

So at this point in time, my analysis is that the
DefaultClassRealmManagerTest is not a valid test when the default
classloader does not have any ScriptEngineFactory... I'm going to commit
a fix, but this should not invalidate the 3.5.1 release

On 11 September 2017 at 01:53, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

With https://github.com/apache/maven-integration-testing/
commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get
Michael's test failures:

Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.7.0_154, vendor: Azul Systems, Inc.
Java home: /usr/lib/jvm/zulu-7-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"


------------------------------------------------------------
-------------------
Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest
------------------------------------------------------------
-------------------
Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128 sec
<<< FAILURE! - in org.apache.maven.classrealm.De
faultClassRealmManagerTest
testMNG6275_mavenApiRealmDefaultParentClassLoader(org.
apache.maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed:
1.12 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
tMNG6275_mavenApiRealmDefaultParentClassLoader(DefaultClassR
ealmManagerTest.java:91)

testMNG6275_coreRealmDefaultParentClassLoader(org.apache.
maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.271 sec
 <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
tMNG6275_coreRealmDefaultParentClassLoader(DefaultClassRealm
ManagerTest.java:99)

testMNG6275_extensionRealmDefaultParentClassLoader(org.
apache.maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed:
0.251 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
tMNG6275_extensionRealmDefaultParentClassLoader(DefaultClass
RealmManagerTest.java:73)

testMNG6275_pluginRealmDefaultParentClassLoader(org.apache.
maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.244 sec
 <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
tMNG6275_pluginRealmDefaultParentClassLoader(DefaultClassRea
lmManagerTest.java:62)

testMNG6275_projectRealmDefaultParentClassLoader(org.apache.
maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.242 sec
 <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
tMNG6275_projectRealmDefaultParentClassLoader(DefaultClassRe
almManagerTest.java:83)

investigating...

On 11 September 2017 at 01:44, Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

Building the source bundles with the binary bundles in the staging repo
using the Dockerfile environments in https://github.com/apache/mave
n-integration-testing/tree/master/environments

Debian JDK 7
===========

Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.7.0_151, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

Debian JDK 8
===========

Linux 11ef1c114b6b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0_141, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

Fedora JDK 8
===========

Linux 54211a0e694e 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.144-5.b01.fc26.x86_64/
jre
Default locale: en_US, platform encoding: ANSI_X3.4-1968
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

IBM JDK 8
========

Linux 199631edceed 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0, vendor: IBM Corporation
Java home: /opt/ibm/java/jre
Default locale: en_US, platform encoding: ANSI_X3.4-1968
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

Asul Zulu JDK 8
=============

Linux 10e8f4e46138 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0_144, vendor: Azul Systems, Inc.
Java home: /usr/lib/jvm/zulu-8-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

If I get time later I'll run the integration tests.

On 11 September 2017 at 00:20, Dan Tran <dant...@gmail.com> wrote:

False alarm, I missed configure global settings.xml, it is missing the
default repository setup

-D

On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana <
tibor.dig...@googlemail.com>
wrote:

> +1:
> 3.5.1 works in my project like a charm ;-)
>
> On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
> stephen.alan.conno...@gmail.com> wrote:
>
> > Hi,
> >
> > We solved 25 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > version=12338964&styleName=Text&projectId=12316922
> >
> > There are 350 issues left in JIRA for Maven core:
> > https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1364/
> >
> > The distributable binaries and sources can be found here:
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/
> >
> > Specifically the zip, tarball and source archives can be found here:
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
bin.tar.gz
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
src.tar.gz
> >
> > Source release checksum(s):
> > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> > bd2059560d
> > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> 69e698eb0e
> >
> > Git tag:
> > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > 094e4e31a5af55bb17be87675da41d9aeca062f3
> >
> > Staging site:
> > https://maven.apache.org/components/ref/3-LATEST/
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Thanks,
> >
> > Stephen.
> >
>
>
>
> --
> Cheers
> Tibor
>





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to