Hi Michael,
two things are coming into my mind:
I stumbled over one thing which is:
Why do we have the tests in maven-compat and not in maven-artifact ?
Shouldn't they be in maven-artifact instead of maven-compat ?
Furthermore if I recap the code and the tests I would think we should
add a test that proves that the given pattern is NOT a SNAPSHOT version...
Something like this:
assertEquals( false, ArtifactUtils.isSnapshot( "1.2.3-20090413X094722-2"));
WDYT ?
Kind regards
Karl Heinz Marbaise
On 06/05/18 21:15, Michael Osipov wrote:
Am 2018-05-06 um 21:08 schrieb Karl Heinz Marbaise:
Hi,
I second MNG-6403 for 3.5.4 we should write a test for this to be sure
this does not happen again...
Do you have anything specific in mind?
I have updated the branch and added a test to ArtifactUtilsTest. Is that
sufficient?
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
