Hi Mark, Seems you found one more thing that I forgot when merging MNG-6059: inheritance of these child.inherit.append.path configurations...
I created MNG-6505 [1] and added the fix to MNG-6059 branch. Can you check that it works as you expect? (notice: with the new child.x.y.inherit.append.path names...) Thank you for the tests and reports: this really helps a lot to improve quality. Regards, Hervé [1] https://issues.apache.org/jira/browse/MNG-6505 Le samedi 3 novembre 2018, 19:11:26 CET Mark Raynsford a écrit : > Let's say I have the following: > > <project> > <modelVersion>4.0.0</modelVersion> > <groupId>com.example</groupId> > <artifactId>a</artifactId> > <version>1.0.0</version> > <packaging>pom</packaging> > <scm child.inherit.append.path="false"> > <url>https://example.com/a</url> > <connection>scm:git:https://example.com/a</connection> > <developerConnection>scm:git:https://example.com/a</developerConnection> > </scm> > </project> > > And then: > > <project> > <modelVersion>4.0.0</modelVersion> > <parent> > <groupId>com.example</groupId> > <artifactId>a</artifactId> > <version>1.0.0</version> > </parent> > <groupId>com.example</groupId> > <artifactId>b</artifactId> > <version>1.0.0</version> > <packaging>pom</packaging> > <scm> > <url>https://example.com/b</url> > <connection>scm:git:https://example.com/b</connection> > <developerConnection>scm:git:https://example.com/b</developerConnection> > </scm> > </project> > > And then: > > <project> > <modelVersion>4.0.0</modelVersion> > <parent> > <groupId>com.example</groupId> > <artifactId>b</artifactId> > <version>1.0.0</version> > </parent> > <groupId>com.example</groupId> > <artifactId>c</artifactId> > <version>1.0.0</version> > <packaging>jar</packaging> > </project> > > So that's com.example:a:1.0.0 → com.example:b:1.0.0 → > com.example:c:1.0.0. > > Would you expect com.example:c:1.0.0 to have > child.inherit.append.path="true" for the (inherited) <scm> element? It > wasn't clear exactly what semantics were intended to be. What I *think* > is happening right now is that the <scm> element in com.example:b:1.0.0 > is assigned a value of child.inherit.append.path="true", because "true" > is the default if something isn't specified and it overrides the value > specified in com.example:a:1.0.0. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
