hboutemy commented on a change in pull request #11: Propagate exceptions to
caller
URL: https://github.com/apache/maven-doxia/pull/11#discussion_r249714608
##########
File path:
doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlParser.java
##########
@@ -269,11 +269,11 @@ private void processMacro( String text, Sink sink )
}
catch ( MacroExecutionException e )
{
- throw new XmlPullParserException( "Unable to execute macro in the
document: " + macroName );
+ throw new XmlPullParserException( "Unable to execute macro in the
document: " + macroName , null, e );
}
catch ( MacroNotFoundException me )
{
- throw new XmlPullParserException( "Macro not found: " + macroName
);
+ throw new XmlPullParserException( "Macro not found: " + macroName,
null, me );
Review comment:
is the original exception really useful in the context of a macro not found?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
