ok, here are the PRs if you prefer: - https://github.com/codehaus-plexus/plexus-utils/pull/62 - https://github.com/codehaus-plexus/modello/pull/30 - https://github.com/apache/maven/pull/236 - https://github.com/apache/maven-help-plugin/pull/4
regards, Hervé Le dimanche 24 février 2019, 10:38:36 CET Enrico Olivelli a écrit : > Great work. > What about creating pull requests on github? It is only a matter of pushing > the 'compare' button. > I am very used to that kind of reviews and I find it very productive > > Enrico > > Il sab 23 feb 2019, 23:00 Hervé BOUTEMY <herve.bout...@free.fr> ha scritto: > > Hi, > > > > work on MPH-160 [1] = add source location in comments to effective > > pom.xml, is > > now ready: I did prepare changes in branches for plexus-utils, modello, > > Maven > > core and maven-help-plugin > > > > I need your review before merging and releasing plexus-utils 3.2.0 and > > Modello > > 1.10.0, then merging into Maven core for 3.6.1 and finally merging into > > maven- > > help-plugin. > > > > In order, the parts to review are: > > > > 1. MNG-6599 branch [2] for MNG-6599 [3] and MNG-6600 [4] = fix modelId and > > track input location for default lifecycle executions > > > > 2. plexus-utils #61 [5] to add input location tracking support for Xpp3Dom > > > > 3. Modello #28 [6] and #29 [7] for xpp3-extended-writer and Xpp3Dom input > > location tracking > > > > 4. MNG-6597 branch [8] for MNG-6597 [9] and MNG-6601 [10] = add input > > location > > tracking for plugins configuration and m-site-p converted reports > > > > 5. and finally MPH-160 branch, which integrates everything to give a nice > > "mvn > > -Dverbose help:effective-pom" that explains every line of an effective pom > > (when used with Maven 3.6.1-SNAPSHOT, does as much as possible when used > > with > > older Maven versions) > > > > If you apply and install locally everything in explained order, you should > > be > > able to see the result for yourself :) > > > > Please comment and second > > > > Regards, > > > > Hervé > > > > > > [1] https://issues.apache.org/jira/browse/MPH-160 > > > > [2] https://github.com/apache/maven/tree/MNG-6599 > > > > [3] https://issues.apache.org/jira/browse/MNG-6599 > > > > [4] https://issues.apache.org/jira/browse/MNG-6600 > > > > [5] https://github.com/codehaus-plexus/plexus-utils/issues/61 > > > > [6] https://github.com/codehaus-plexus/modello/issues/28 > > > > [7] https://github.com/codehaus-plexus/modello/issues/29 > > > > [8] https://github.com/apache/maven/tree/MNG-6597 > > > > [9] https://issues.apache.org/jira/browse/MNG-6597 > > > > [10] https://issues.apache.org/jira/browse/MNG-6601 > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
