Robert, I did *not* use the source zip. git clone https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10
I see there is a new line, but the checkstyle does not care if you put one or two lines. No idea why. Even if you go to the target and run it from the folder c:\vcs\github\maven-checkstyle-plugin\target\it\MCHECKSTYLE-54\ it's the same as if you run the project root - mvn verify -P run-its,quality-checks *mvn -nsu checkstyle:check* [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @ mcheckstyle-54 --- [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml ruleset. [ERROR] src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] (misc) NewlineAtEndOfFile: File does not end with a newline. [ERROR] src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] (misc) NewlineAtEndOfFile: File does not end with a newline. [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3.450 s [INFO] Finished at: 2019-05-13T23:42:55+02:00 [INFO] Final Memory: 12M/193M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException On Mon, May 13, 2019 at 10:29 PM Robert Scholte <[email protected]> wrote: > This can happen when source-release.zip was created on a different OS > compared to the verifying OS. > > With Git it will switch to the line endings of the operating system, but > with a zip that's not possible. > > I'd say not blocking, but the IT needs to be fixed to handle these > situations. > > Robert > > > On Mon, 13 May 2019 21:55:27 +0200, Enrico Olivelli <[email protected]> > > wrote: > > > Tibor > > It is strage all its are passing on CI. > > Are you sure you have correcly unpacked the package? > > > > > > Il lun 13 mag 2019, 21:23 Tibor Digana <[email protected]> ha > > scritto: > > > >> checked the sha512 of src zip, ok > >> checked the build, failed (mvn verify -P run-its,quality-checks) > >> > > > > What is 'quality-checks' profile? I have never heard about it > > > > Enrico > > > > > >> [INFO] Building: MCHECKSTYLE-54\pom.xml > >> [INFO] MCHECKSTYLE-54\pom.xml ........................... > >> FAILED > >> (5.3 s) > >> > >> *Mcheckstyle54.java:[1] (misc) NewlineAtEndOfFile: File does not end > >> with a > >> newline.* > >> > >> but I checkted this file and it ends with a new line. Is it bug in the > >> Checkstyle dependency? > >> > >> [INFO] BUILD FAILURE > >> [ERROR] Failed to execute goal > >> org.apache.maven.plugins:maven-pmd-plugin:3.8:cpd-check (cpd-check) on > >> project maven-checkstyle-plugin: You have 1 CPD duplication. > >> > >> There are exactly the same methods. That's why CPD fails, see > >> CheckstyleViolationCheckMojo L813 > >> AbstractCheckstyleReport L581 > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> On Mon, May 13, 2019 at 11:52 AM Enrico Olivelli <[email protected]> > >> wrote: > >> > >> > Hi, > >> > > >> > We solved 13 issues: > >> > > >> > > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342397&styleName=Text&projectId=12317223 > >> > > >> > Please note that this version now only supports CheckStyle 8+ and > >> Java 8 > >> > (as required by latest Checkstyle) > >> > > >> > There are still a couple of issues left in JIRA: > >> > > >> > > >> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20XXXXXXXXXX%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC > >> > > >> > Staging repo: > >> > https://repository.apache.org/content/repositories/maven-1503/ > >> > > >> > > >> > https://repository.apache.org/content/repositories/maven-1503/org/apache/maven/plugins/maven-checkstyle-plugin/3.1.0/maven-checkstyle-plugin-3.1.0-source-release.zip > >> > > >> > Source release checksum(s): > >> > maven-checkstyle-plugin-3.1.0-source-release.zip sha512: > >> > > >> > > >> > eca46edb4d2f6cf2e250169ce5d5e510781b4bba116cc7b5655797cdb109ccdb0da883a1761347c6e2c77fe58395aff17e45c46d85a8a823340ae2b11c92852e > >> > > >> > Staging site: > >> > > >> > https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/ > >> > > >> > Guide to testing staged releases: > >> > > >> https://maven.apache.org/guides/development/guide-testing-releases.html > >> > > >> > Vote open for at least 72 hours. > >> > > >> > [ ] +1 > >> > [ ] +0 > >> > [ ] -1 > >> > > >> > > >> > Enrico Olivelli > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
