Hi Michael,
On 27.05.19 21:26, Michael Osipov wrote:
Am 2019-05-27 um 20:53 schrieb Karl Heinz Marbaise:
Hi Michael,
On 26.05.19 23:15, Michael Osipov wrote:
Folks,
I am trying to investigate an issue with MINSTALL 3.0.0-M1 for MNG-6556
where the GroupRepositoryMetadata file is simply not written to disk,
thus the IT for MNG-3372 is failing.
As far as I can see everything in Maven 2 for this task has been moved
to Maven Artifact Transfer, Maven31ArtifactInstaller.
I do see in
for ( ArtifactMetadata metadata : mavenArtifact.getMetadataList() )
everything I need is there, but the instanceof tests simply ignore this
kind of metadata and it is never persisted to disk.
I am a bit lost because it looks like a several issue in our codebase.
Is the IT flawed and should exclude the Maven version which will include
MNG-6556 or am I just too stupid to see the obvious?
Here is a simple reproducer:
* Clone MINSTALL
I suppose you maven-install-plugin git repo? ..
Yes.
* Open pom.xml and add MINSTALL 3.0.0-M1 to override from parent
* Delete org/apache/maven/plugins from your local repo
* Use Maven 3.6.1 to install MINSTALL 3.0.0-M2-SNAPSHOT
maven-metadata-local.xml will *not* be generated, remove change in
pom.xml and repeat, metadata file is there.
Would be nice if someone can confirm this.
Hm...I've tried your steps:
plugins (master)$ ls -la maven-install-plugin/
3.0.0-M1/ 3.0.0-M2-SNAPSHOT/
maven-metadata-local.xml
plugins (master)$ ls -la maven-install-plugin/3.0.0-M2-SNAPSHOT/
total 96
drwxr-xr-x 6 khmarbaise staff 192 May 27 20:35 .
drwxr-xr-x 5 khmarbaise staff 160 May 27 20:35 ..
-rw-r--r-- 1 khmarbaise staff 231 May 27 20:35 _remote.repositories
-rw-r--r-- 1 khmarbaise staff 29457 May 27 20:35
maven-install-plugin-3.0.0-M2-SNAPSHOT.jar
-rw-r--r-- 1 khmarbaise staff 6346 May 27 20:30
maven-install-plugin-3.0.0-M2-SNAPSHOT.pom
-rw-r--r-- 1 khmarbaise staff 739 May 27 20:35
maven-metadata-local.xml
plugins (master)$ cat
maven-install-plugin/3.0.0-M2-SNAPSHOT/maven-metadata-local.xml
<?xml version="1.0" encoding="UTF-8"?>
<metadata modelVersion="1.1.0">
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-install-plugin</artifactId>
<version>3.0.0-M2-SNAPSHOT</version>
<versioning>
<snapshot>
<localCopy>true</localCopy>
</snapshot>
<lastUpdated>20190527183515</lastUpdated>
<snapshotVersions>
<snapshotVersion>
<extension>jar</extension>
<value>3.0.0-M2-SNAPSHOT</value>
<updated>20190527183515</updated>
</snapshotVersion>
<snapshotVersion>
<extension>pom</extension>
<value>3.0.0-M2-SNAPSHOT</value>
<updated>20190527183515</updated>
</snapshotVersion>
</snapshotVersions>
</versioning>
</metadata>
plugins (master)$
and I get a written maven-metadata-local.xml file?
Do I miss something?
Yes, you do. I mean this maven-metadata-local.xml:
<?xml version="1.0" encoding="UTF-8"?>
<metadata>
<plugins>
<plugin>
<name>Other Name</name>
<prefix>other-plugin</prefix>
<artifactId>other-plugin</artifactId>
</plugin>
</plugins>
</metadata>
This is generated a level above the group id. This has to present, but
is not.
Ah sorry missed that ...
You are right now I see the issue ...
But the question is:
Why is this file needed and in particular by whom? I have to admit that
I haven't dived into the IT's for that...are those files only checked by
the IT's or is this related to something different?
Kind regards
Karl Heinz Marbaise
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
