Message:

   The following issue has been closed.

   Resolver: Emmanuel Venisse
       Date: Fri, 23 Apr 2004 12:20 PM

Applied.
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPJCOVERAGE-7

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPJCOVERAGE-7
    Summary: Custom stylesheet for jcoverage plugin
       Type: Improvement

     Status: Closed
   Priority: Major
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-jcoverage-plugin
   Fix Fors:
             1.0.4
   Versions:
             1.0.3

   Assignee: Emmanuel Venisse
   Reporter: J�rg Prante

    Created: Sun, 11 Apr 2004 4:38 PM
    Updated: Fri, 23 Apr 2004 12:20 PM

Description:
The stylesheet in plugin.jelly is fixed to style.css in the plugin resource directory 
(in case the template name is not set to 'jcoverage').

It would be much more convenient to allow a custom stylesheet setting, similar to the 
javadoc plugin custom stylesheet setting.

An appropriate name of a new property would be maven.jcoverage.report.stylesheet

This can be easily accomplished by the following example diff code in plugin.jelly:

--- plugin.jelly.old    2004-04-11 22:26:54.000000000 +0200
+++ plugin.jelly        2004-04-11 22:19:27.000000000 +0200
@@ -179,7 +179,11 @@
               <ant:path refid="jcoverage.classpath"/>
             </ant:classpath>
           </report>
-          <ant:copy file="${plugin.resources}/style.css" 
todir="${maven.coverage.dir}"/>
+          <j:set var="stylesheet" value="${maven.jcoverage.report.stylesheet}"/>
+          <j:if test="${stylesheet.isEmpty()}">
+            <j:set var="stylesheet" value="${plugin.resources}/style.css"/>
+          </j:if>
+          <ant:copy file="${stylesheet}" tofile="${maven.coverage.dir}/style.css"/>
           <jcoverage:report
               dataFile="${maven.jcoverage.dir}/coverage.xml"
               outputDir="${maven.coverage.dir}"/>

I would appreciate it very much to have this feature in the next version of this 
plugin.

Many thanks!


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to