The community has no/few resources thus for sure we need to think to it first. If we change the current setup and make it too complex we know that it will be useless and people won't use it (I'm sure that Jason isn't the only one to have done such kind consultancy). The idea of having tags/branches could be an option if it's really a problem for the community and there is a gain to remove them. I am just not sure about the gain. They are skipped. Will we reduce the build time without them ?
On Mon, Dec 9, 2019 at 11:09 AM Tibor Digana <tibordig...@apache.org> wrote: > Having some comparison tests might be good to have especially if an old > feature is maintained in the master. > I am not saying that the old behavior was right. A fix can be backported > too. > > We should answer some questions before making any decision: > > 1. Do we have the effort to maintain the old versions? > 2. We are testing the development version. > Would we branch the old Tags, maintain them and submit their DIST to > the common/current ITs? > 3. Would we rather branch the ITs together with the Maven-Core? (ITs_branch > : Maven_branch = 1:1) > > I think the effort was discussed a year ago and we decided to deprecate > some versions. > 4. So the non-deprecated versions should be maintained and tested? > > On Mon, Dec 9, 2019 at 10:22 AM Arnaud Héritier <aherit...@gmail.com> > wrote: > > > I agree with what Jason shared. > > It's a reality. Probably a sad one but a lot of users are still running > on > > ancient version of Maven (didn't we have a discussion recently about the > > minimum version of Java to support ?) > > There are some kind of business where you don't touch what is doing the > > job. It is especially true when you outsource the maintenance of your > > software. > > > > Having a separate repository and such big referential of tests is from my > > POV one of the best thing done in the project. > > Having a separate repo avoids that you refactor a test with the codebase > > and thus you have to explicitly update the IT if you change something. > > Having the whole history is helping to maintain old versions and even if > > it's not done by us (the community) it is useful for others > > > > On Mon, Dec 9, 2019 at 8:40 AM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > Karl, > > > In my opinion I would like to drop anything that is not useful. > > > > > > I would also like to merge the integration tests repository with the > > maven > > > core repository, this way it is clear that the ITs are for the same > > > version. > > > > > > Can you tell more about the reasons behind having two separate repos? > > > > > > Enrico > > > > > > Il lun 9 dic 2019, 07:59 Jason van Zyl <ja...@vanzyl.ca> ha scritto: > > > > > > > Please don’t ever remove any of the integration tests. If they don’t > > > apply > > > > to specific versions they are skipped as you see and there’s no harm. > > > > > > > > They serve as a historical record of what features work in a > particular > > > > version. I’ve not done specific Maven work for any customer recently, > > but > > > > it has happened where in a highly regulated industry (nuclear, > > aerospace) > > > > changes are prohibitively expensive and so no one wants to upgrade > > > anything > > > > especially build tools. They will make the minimal patch from > anything > > > > upstream to make their changes work. I’ve helped consultants make > small > > > > patches in Maven, and used the integration tests to verify everything > > > else > > > > worked. > > > > > > > > Yes, they will always be in the history but I can’t imagine it would > be > > > > very nice for someone in that situation to go hunting through the > > history > > > > to bring back tests in order to verify a change. I think we would all > > be > > > > pretty shocked how many people still actually use Maven 2.x. The > > support > > > > cycle on things like airplanes is upwards of 50 years and no one will > > > > change a thing if they don’t have to. I’m sure there’s lots of Maven > > 1.x > > > > and Ant in a bunch of nooks and crannies for that very reason. > Didn’t > > > > someone just post about writing a book about Maven 2.x? :-) > > > > > > > > JvZ > > > > > > > > > On Dec 8, 2019, at 2:10 PM, Karl Heinz Marbaise <khmarba...@gmx.de > > > > > > wrote: > > > > > > > > > > Hi, > > > > > I'm diving a little bit into the integration tests of maven core... > > > > > > > > > > and I realized that at the moment this list of IT's is SKIPPED > > > > > based on the version of Maven Core: > > > > > > > > > > > mng5889FindBasedir(MvnFileLongOptionModule).................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1) > > > > > > mng5889FindBasedir(MvnFileShortOptionModule)................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1) > > > > > > mng5889FindBasedir(MvnFileShortOption)......................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1) > > > > > > mng5889FindBasedir(MvnFileLongOption).......................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1) > > > > > > mng5805PkgTypeMojoConfiguration(PkgTypeMojoConfiguration)...SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (3.3.3,3.5.0-alpha) > > > > > > mng4428FollowHttpRedirect(itHttpToHttps)....................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.2.0,2.2.0] > > > > > > mng4428FollowHttpRedirect(itHttpsToHttp)....................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.2.0,2.2.0] > > > > > > mng4279WagonProviderFailover(it)............................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.2.1,3.0-alpha-1) > > > > > > mng4254SelectableWagonProviders(DefaultHttpsWagon)..........SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1) > > > > > > mng4254SelectableWagonProviders(DefaultHttpWagon)...........SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1) > > > > > > mng4254SelectableWagonProviders(SettingsUsage)..............SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1) > > > > > > mng4254SelectableWagonProviders(CliUsage)...................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1) > > > > > > mng4126ParentProfilesXml(itReactorBuild)....................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > [2.0,2.1.0),(2.1.0,3.0-alpha-1) > > > > > > mng4126ParentProfilesXml(itChildOnlyBuild)..................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > [2.0,2.1.0),(2.1.0,3.0-alpha-1) > > > > > > mng4086ExplicitPluginMetaversion(itRelease).................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0.6,3.0-alpha-3) > > > > > > mng4086ExplicitPluginMetaversion(itLatest)..................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0.6,3.0-alpha-3) > > > > > > mng4036ParentResolutionFromSettingsRepo(itLegacyLayout).....SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-3) > > > > > > mng3991ValidDependencyScope(it).............................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [4.0,) > > > > > > mng3983PluginResolutionFromProfileRepos(itFromProfilesXml)..SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > mng3970DepResolutionFromProfileRepos(itFromProfilesXml).....SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > mng3948ParentResolutionFromProfileRepos(itFromProfilesXml)..SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > mng3933ProfilesXmlActivation(itMNG3933).....................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > mng3885UniqueVersionFromParentProfile(itUniqueVersionReactor)SKIPPED > > - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1) > > > > > > > mng3885UniqueVersionFromParentProfile(itUniqueVersionStandalone)SKIPPED > > > > > - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1) > > > > > > > > > > > > > > > mng3885UniqueVersionFromParentProfile(itNonUniqueVersionStandalone)SKIPPED > > > > > - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1) > > > > > > > mng3885UniqueVersionFromParentProfile(itNonUniqueVersionReactor)SKIPPED > > > > > - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1) > > > > > > mng3760BaseUriProperty(itMNG3760)...........................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.1.0-M1,3.0-alpha-1),(3.0-alpha-2,3.5.4) > > > > > > mng3760BaseUriProperty(itMNG3760SystemPropertyOverride).....SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.1.0-M1,3.0-alpha-1),(3.0-alpha-2,3.5.4) > > > > > > mng3743ForkWithPluginManagement(itMNG3743)..................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.1-SNAPSHOT) > > > > > > mng3704LifecycleExecutorWrapper(itMNG3704)..................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0.9,3.0-alpha-1) > > > > > > mng3599useHttpProxyForWebDAV(itUseHttpProxyForWebDAV).......SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.9,3.3.9) > > > > > > mng3599useHttpProxyForWebDAV(itUseHttpProxyForHttp).........SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.9,3.3.9) > > > > > > mng3530DynamicPOMInterpolation(itMNG3530_POMProperty).......SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.0-alpha-1) > > > > > > mng3530DynamicPOMInterpolation(itMNG3530_BuildPath).........SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.0-alpha-1) > > > > > > > > > > > > > > > mng3530DynamicPOMInterpolation(itMNG3530_ResourceDirectoryInterpolation)SKIPPED > > > > > - Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.0-alpha-1) > > > > > > mng3428PluginDescriptorArtifactsIncomplete(itMNG3428).......SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.0-alpha-1) > > > > > > mng3271DefaultReportsSuppression(itMNG3271).................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1) > > > > > > mng3221InfiniteForking(itMNG3221a)..........................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.0-alpha-1) > > > > > > mng3221InfiniteForking(itMNG3221b)..........................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.0-alpha-1) > > > > > > > mng3106ProfileMultipleActivators(ProfilesWithMultipleActivators)SKIPPED > > > > > - Maven version 3.7.0-SNAPSHOT not in range (2.0.9,3.2.2) > > > > > > mng3057VersionExprTransformations(itMNG3057)................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.1.0,2.1.1) > > > > > > mng2883LegacyRepoOffline(DependencyUnresolvable)............SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1) > > > > > > mng2883LegacyRepoOffline(PluginUnresolvable)................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1) > > > > > > mng2883LegacyRepoOffline(ParentUnresolvable)................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1) > > > > > > mng2878DefaultReportXmlImport(itMNG2878)....................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (,3.0-alpha-1) > > > > > > mng2562Timestamp(itCustomFormat)............................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.2.2) > > > > > > mng2562Timestamp(itDefaultFormat)...........................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.2.2) > > > > > > mng2562Timestamp(itSameValueAcrossModules)..................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.2.2) > > > > > > mng2539PluginDependenciesComeFromPluginRepos(itMNG2539).....SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0.4,3.0-alpha-3) > > > > > > mng1999DefaultReportsInheritance(itInheritSuppression)......SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1) > > > > > > mng1999DefaultReportsInheritance(itOverrideSuppression).....SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1) > > > > > > mng1908LegacySnapshotUpdate(itMNG1908)......................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-3) > > > > > > mng1830ShowVersion(Version).................................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > > > (2.0.10,2.1.0-M1),(2.1.0-M1,3.0-alpha-1),[3.0-alpha-3,3.2) > > > > > > mng0731LegacyRepoLayout(itMNG731)...........................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-3) > > > > > > mng0469ReportConfig(itReportConfigOverridesBuildDefaults)...SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0.0,3.0-alpha-1) > > > > > > 0145ReactorWithIncludesExcludes(itCustomExcludes)...........SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > 0145ReactorWithIncludesExcludes(itDefaultIncludesExcludes)..SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > 0145ReactorWithIncludesExcludes(itCustomIncludes)...........SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > 0039ReleasePomInReactor(it0039).............................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1) > > > > > > 0036ReleasePom(it0036)......................................SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range (2.0,3.0-alpha-1) > > > > > > mng6352PrintVersion(itShouldPrintVersionAtTopAndAtBottom)...SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > [3.5.3-SNAPSHOT,3.5.4-SNAPSHOT] > > > > > > mng6352PrintVersion(itShouldPrintVersionInAllLines).........SKIPPED - > > > > > Maven version 3.7.0-SNAPSHOT not in range > > > [3.5.3-SNAPSHOT,3.5.4-SNAPSHOT] > > > > > > > > > > > > > > > which are 62 IT's in total > > > > > > > > > > Should we keep them or should we remove them? > > > > > > > > > > Several of them are Maven 2 related...? > > > > > > > > > > Kind regards > > > > > Karl Heinz Marbaise > > > > > > > > > > [1]: https://issues.apache.org/jira/browse/MNG-6744 > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > Thanks, > > > > > > > > Jason > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > > > > > -- > > ----- > > Arnaud Héritier > > http://aheritier.net > > Mail/GTalk: aheritier AT gmail DOT com > > Twitter/Skype : aheritier > > > -- ----- Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
