[EMAIL PROTECTED] wrote on 25/04/2004 12:26:22 PM:

> brett       2004/04/24 19:26:22
> 
>   Modified:    eclipse  project.xml
>                eclipse/src/plugin-resources/templates classpath.jelly
>                eclipse/xdocs changes.xml
>   Log:
>   PR: MPECLIPSE-21
>   Submitted by: Boris Boehlen
>   use sourcemods

I had a problem with this patch, in that it blindy assumed the conditions 
of the sourceModification are met, e.g.

>   +    <j:set var="excluding" value=""/>
>   +    <j:forEach var="sm" items="${pom.build.sourceModifications}">
>   +      <j:forEach var="exclude" items="${sm.excludes}">
>   +        <j:set var="excluding" value="${excluding},${exclude}"/>
>   +      </j:forEach>
>   +    </j:forEach>
>   +    <j:set var="excluding">${excluding.substring(1)}</j:set> 
>   +    <classpathentry kind="src" path="${srcDir}" 
excluding="${excluding}" />

Note that the class in sourceModifications isn't used. 

I'd rather we didn't apply this one.
--
dIon


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to