removing Maven 2 code is a good simplification
but FYI it won't remove dependency on plexus-classworld: it's the core of all 
plugins classloading mechanism to have independant plugins

didn't yet have time yet to dig, but perhaps the way maven-site-plugin invokes 
reporting plugins causes some dependencies on classloaders: really need the 
stacktrace, because I know that the way such low level reporting plugin 
classloading exceptions are reported are reported at the end against maven-
site-plugin by Maven core, even if it was the reporting plugin that reported 
an issue to the maven-site-plugin

Regards,

Hervé

Le dimanche 24 mai 2020, 14:02:54 CEST Elliotte Rusty Harold a écrit :
> I still don't have  full grasp of the cause, but I think we can remove
> our dependency on plexus-classworlds completely by ripping out some
> Maven 2 support. See
> 
> https://github.com/apache/maven-site-plugin/pull/24/f
> 
> On Sun, May 24, 2020 at 6:16 AM Elliotte Rusty Harold
> 
> <elh...@ibiblio.org> wrote:
> > getInputLocation seems to have been added in plexus-utils 3.2.0.
> > 
> > The reproducible builds work for maven-site-plugin upgraded from
> > plexus 3.0.x to 3.3.0 in
> > https://github.com/apache/maven-site-plugin/commit/19be00a9bf2a410abb71324
> > 87dc24055060b2c70#diff-600376dffeb79835ede4a0b285078036
> > 
> > It's not immediately clear to me how the classpath for all this is
> > pulling in an earlier version of plexus-utils since maven-site-plugin
> > declares that dependency directly, but that's what seems to be
> > happening.
> > 
> > On Sun, May 24, 2020 at 6:02 AM Karl Heinz Marbaise <khmarba...@gmx.de> 
wrote:
> > > Hi to all,
> > > 
> > > I've stumbled upon the following problem during the site generation
> > > 
> > > mojo-parent (issue-105)$ mvn site site:stage
> > > ..
> > > [INFO]
> > > [INFO] --- maven-site-plugin:3.9.0:site (default-site) @ mojo-parent ---
> > > [INFO] configuring report plugin
> > > org.apache.maven.plugins:maven-plugin-plugin:3.6.0
> > > [INFO] preparing maven-plugin-plugin:report report requires
> > > 'process-classes' forked phase execution
> > > [INFO]
> > > [INFO] >>> maven-plugin-plugin:3.6.0:report > process-classes @
> > > mojo-parent >>>
> > > [INFO]
> > > [INFO] --- maven-enforcer-plugin:1.4:enforce (mojo-enforcer-rules) @
> > > mojo-parent ---
> > > [INFO]
> > > [INFO] <<< maven-plugin-plugin:3.6.0:report < process-classes @
> > > mojo-parent <<<
> > > [INFO] 'process-classes' forked phase execution for
> > > maven-plugin-plugin:report report preparation done
> > > [INFO] 1 report detected for maven-plugin-plugin:3.6.0: report
> > > [INFO] configuring report plugin
> > > org.apache.maven.plugins:maven-changes-plugin:2.11
> > > [INFO] 1 report configured for maven-changes-plugin:2.11: github-report
> > > [INFO] configuring report plugin
> > > org.apache.maven.plugins:maven-checkstyle-plugin:2.16
> > > [INFO] 1 report configured for maven-checkstyle-plugin:2.16: checkstyle
> > > [INFO] configuring report plugin
> > > org.apache.maven.plugins:maven-javadoc-plugin:3.2.0
> > > [INFO]
> > > ------------------------------------------------------------------------
> > > [INFO] BUILD FAILURE
> > > [INFO]
> > > ------------------------------------------------------------------------
> > > [INFO] Total time: 2.144 s
> > > [INFO] Finished at: 2020-05-24T11:50:11+02:00
> > > [INFO] Final Memory: 30M/128M
> > > [INFO]
> > > ------------------------------------------------------------------------
> > > [ERROR] Failed to execute goal
> > > org.apache.maven.plugins:maven-site-plugin:3.9.0:site (default-site) on
> > > project mojo-parent: Execution default-site of goal
> > > org.apache.maven.plugins:maven-site-plugin:3.9.0:site failed: An API
> > > incompatibility was encountered while executing
> > > org.apache.maven.plugins:maven-site-plugin:3.9.0:site:
> > > java.lang.NoSuchMethodError: 'java.lang.Object
> > > org.codehaus.plexus.util.xml.Xpp3Dom.getInputLocation()'
> > > [ERROR] -----------------------------------------------------
> > > [ERROR] realm =   
> > > plugin>org.apache.maven.plugins:maven-site-plugin:3.9.0
> > > [ERROR] strategy =
> > > org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> > > [ERROR] urls[0] =
> > > file:/Users/khmarbaise/.m2/repository/org/apache/maven/plugins/maven-sit
> > > e-plugin/3.9.0/maven-site-plugin-3.9.0.jar
> > > 
> > > 
> > > This can be reproduced with 3.0.5 up to 3.6.1.
> > > 
> > > Versions 3.6.2 and 3.6.3 are working fine.
> > > 
> > > This means using maven-site-plugin 3.9.0 only working with Maven 3.6.2+
> > > ...in contradiction to the site[1] which says it is requirement 3.0..
> > > 
> > > Or has someone a different explanation for this?
> > > 
> > > Kind regards
> > > Karl Heinz Marbaise
> > > 
> > > 
> > > [1]: https://maven.apache.org/plugins/maven-site-plugin/plugin-info.html
> > > 
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > --
> > Elliotte Rusty Harold
> > elh...@ibiblio.org





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to