abelsromero opened a new pull request #35: URL: https://github.com/apache/maven-doxia/pull/35
There's still a thing to fix with test begin discussed in https://issues.apache.org/jira/browse/DOXIA-614. Other than that, the changes are all done and the tests pass. I tried to minimize changes so no tests have been modified and all works as-is. To facilitate review, here is a diagram with changes. Green for added elements, red for removed. . Some observations open for discussion: - Used null insteall of empty string to represent there's no reference at all. I found the empty string to be ambiguous. I noted that `AptParser`, `ConfluenceParser` and `TwikiParser` use empty string, but I consider this implementation specific. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
