I don't fully grok the issue at hand and do not feel comfortable deciding between whether this works or not. When I try to write complicated multithreaded code that needs to synchronize between threads, devs who truly understand this usually find bugs in my work without looking very hard.
It would be safest for you and Tibor to resolve this before the plugin is released. If that doesn't happen, we can look for a real multi-threading expert (not me) to way in on this. On Sun, Jul 19, 2020 at 3:52 PM Michael Osipov <micha...@apache.org> wrote: > > Am 2020-07-18 um 19:17 schrieb Elliotte Rusty Harold: > > Michael, > > > > Could you address Tibor's concerns about your solution to [MRESOLVER-123]? > > > > https://github.com/apache/maven-resolver/pull/65 > > So I did, the code complies to the contract of the SynContextFactory > interface as well as to the contract of ReentrantReadWriteLock. I truly > don't understand Tibor's concerns. He questions the design of > SyncContextFactory, but this is the wrong forum to discuss it. It should > be separate issue. > > Do you have any concerns since you approved the PR? > > M > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Elliotte Rusty Harold elh...@ibiblio.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
